Adding the rare gun H&K USC 45 carbine #58636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
json-styled
github-actions
bot
added
Mods
github-actions
bot
added
the
BasicBuildPassed
bombasticSlacks
approved these changes
Jun 23, 2022
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
|
No bonus range like the CX4 Storm gives to 9mm? |
That's a good point. Does anyone know the formula being used to determine range increases like that? Average carbine range seems to be approximately 36, it looks like the CX4 boosts the 9mm to 32. Applying the same +20 modifier would land the range of the USC at exactly 36 as well. |
github-actions
bot
added
BasicBuildPassed
tornikeo
pushed a commit
to tornikeo/Cataclysm-DDA
that referenced
this pull request
Jun 26, 2022
* Add USC 45 carbine * Always with the linting * Generic guns migration already * Text style * Update data/json/items/gun/45.json Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> * Update data/json/items/gun/45.json Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> * Added range increase Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Drew4484
pushed a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
Jun 26, 2022
* Add USC 45 carbine * Always with the linting * Generic guns migration already * Text style * Update data/json/items/gun/45.json Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> * Update data/json/items/gun/45.json Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> * Added range increase Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds rare gun - H&K USC 45 Carbine"
Purpose of change
Adds the uncommon, civilian carbine variant of the UMP submachine gun, the USC 45 Carbine. This fills a neglected role for 45 ACP ammunition, which does not have any rifles in its niche, while providing the interesting addition of a high-accurary, low damage long gun.
Describe the solution
Adds the USC 45 carbine and its magazines to the rare gun spawn tables. All stats were pulled from manufacturer pages whenever possible and damage was assigned per the table under GAME_BALANCE.md
Describe alternatives you've considered
Feeling kind of sad whenever I loot yet another UMP I'll never use.
Testing
Spawned all items and verified they behaved as expected.
Additional context
https://hk-usa.com/hk-models/usc/
https://promagindustries.com/hk-usc-45-acp-carbine-10-rd-black-polymer/
https://promagindustries.com/hk-usc-45-acp-carbine-15-rd-black-polymer/
https://promagindustries.com/hk-usc-45-acp-carbine-20-rd-black-polymer/
https://hk-usa.com/wp-content/uploads/USC-Operators-Manual-8_3_20.pdf