Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VZ. 58 7.62x39mm rifles #58933

Merged
merged 22 commits into from Jul 11, 2022
Merged

VZ. 58 7.62x39mm rifles #58933

merged 22 commits into from Jul 11, 2022

Conversation

DoctorBoomstick
Copy link
Contributor

Summary

Content "adds the 7.62x39mm VZ. 58 P, VZ. 58 V, and VZ. 58 Tactical Sporter to the game."

Purpose of change

there was no real purpose for adding these guns, save for the fact that I do happen to be quite partial to a fine Czech VZ carbine, and wanted it to be in the game. Also, the Tactical Sporter is relatively common in the real world, with actual VZ originals being some what present in the US as well in the form of imports. Apart for that, this PR just aims at expanding the list of 7.62x39mm rifles, because one just can’t ever have enough guns when the Blob comes knocking.

Describe the solution

I have added, in no particular order, the VZ. 58 P, 58 V, and 58 Tactical Sporter rifles to the game, as well as their associated item spawns and magazines.
The VZ. 58 P is a standard automatic rifle that uses proprietary magazines. It is, in game terms, functionally the same as an AKM, save for being shorter, lighter, and overall smaller. The V model has a buttstock built into it, whilst the Tactical Sporter has a buttstock, muzzle break, and side rail.

Describe alternatives you've considered

possibly adding the IWI Galil rifle and associated variants first.

Testing

spawned in with each rifle and a collection of magazines, and went through systematically firing rounds off with each weapon, and testing the associated gun mods.

Additional context

VZ 58 Tactical 762x39mm - AtlanticFirearms.com
http://www.theballisticassistant.com/vz-58-purchase-the-parts-kit-and-receiver/
https://www.thetruthaboutguns.com/gun-review-czech-vzor-58/
https://www.youtube.com/watch?v=iCqElIDUzeI

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Magazines Ammo holding items and objects. Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 3, 2022
@DoctorBoomstick
Copy link
Contributor Author

@anothersimulacrum, with regards to the VZ. 58 V, the reason why I made it be its own thing was to create a distinction between it and the regularly issued gun, as they were two different firearms used for two different tasks. Though, I suppose that since the whole variants system exists for a situation just like this, it only makes sense to utilise it.
regards the commonality of the VZ when put up against other rifles, I got to say, even I don't know why I made it be that common. thanks for pointing it out, and it'll be fixed shortly.

Copy link
Contributor

@TheShadowFerret TheShadowFerret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just grammar fixes, as @anothersimulacrum already got the variant comment I was going to make.

  1. Czechoslovak is only three letters from the full Czechoslovakian
  2. vz. 58 isn't supposed to be capitalized(I'd keep it caps for the generic name)
    image
    ~Your first link from Atlantic Firearms
  3. Cold War

Example of fix below, just apply to the others.

  1. No stripper clips?

data/json/items/gun/762.json Outdated Show resolved Hide resolved
data/json/items/gun/762.json Outdated Show resolved Hide resolved
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
@DoctorBoomstick
Copy link
Contributor Author

@TheShadowFerret, Thanks as ever for the changes to the grammar and things of that nature, surprisingly difficult to catch those mistakenly uncapitalized/ capitalised letters when working with a screen reader. Now, few things here.
Re, stripper clips. Firstly, what I’ve seen points at the VZ being able to make use of standard SKS clips, which we’ve already got in the game. Secondly, to my knowledge at least, there is no current way to be able to use stripper clips on a rifle with an empty mag still inserted, like how they’d be used on real VZs. Essentially, as you might/ probably already know, IRL, you’d pull open your action and feed the clip’s rounds down into the magazine, thus removing the need of having to take the mag out. Again, far as I know you can’t do this with our guns in game yet, so adding clips is sort of a fruitless venture, and this is something that’ll be a factor in the future when I add things like Enfield rifles, which are also meant to use charger stripper clips to fill their own detachable mags. If this is something that you can do and that I’m just not aware of, that’d be great and I’d 100% look at fixing it accordingly.
Re, magazine names. Fair point, I made them be that way cause I had removed the, “58,” designation within the names of the actual rifles, so I wanted to keep consistency.
Re, the folding buttstock. Again, another fair point, I accidentally for some reason had a brain fart and forgot that that field doesn’t let the mods be removed from the actual weapon.

@anothersimulacrum
Copy link
Contributor

I think a variant is reasonable for the magazine names, fwiw.

DoctorBoomstick and others added 3 commits July 4, 2022 08:59
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
…58 V a variant of the .58 P, with appropriate mod groups, adds the guns and magazines to the generic guns migration lists, makes mods default rather than built in.
@github-actions github-actions bot added Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Mods Issues related to mods or modding Mods: Generic Guns Anything to do with Generic Guns labels Jul 4, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 4, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 4, 2022
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 4, 2022
@tinukedaya
Copy link
Contributor

Just want mention, that the 58 is actually a bit more important in the name than the "vz."

the "Sa vz.58" is short for "Samopal vzor 58" which can be translated as "Machine rifle model 58" so using vz as a name for the gun makes not much sense.

@DoctorBoomstick
Copy link
Contributor Author

@tinukedaya I didn’t consider that point when naming the rifle’s variants, though, thinking about it, there is no reason why “58” shouldn’t be in the name to begin with. So, I’ll likely go through and just rename the rifles to the, “vz. 58 combat rifle,“ rather than just the, “VZ combat rifle,” cause as you said, the way it's named currently doesn't make much sense.

…y itself didn’t make sense from a taxonomy point of view. Also removes the magazine variants, as the distinction is no longer needed.
… into VZ58

fixes some git related merge errors.
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 5, 2022
@Zireael07
Copy link
Contributor

@DoctorBoomstick: Not a Czech or Slovak native speaker but I'm almost certain "vz. 58" is parallel to Polish "wz 44", i.e. the letters stand for "wzór" (design) and are followed by the year the weapon was designed in. I know the pattern stands for both guns and bayonets.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 5, 2022
… tactical rifle,” to maintain consistency between rifle and magazine names.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A modern semi-automatic clone of the Czechoslovakian produced vz. 58 assault rifle, chambered in the Soviet 7.62x39mm cartridge. Built off of surplus vz. 58 parts, the rifle makes use of additional American made components such as the receiver, barrel and buttstock to comply with US importation laws. Featuring an extended 16 inch barrel, an M4 style stock adapter and tube, and an integrated side rail for optics mounting, this Cold War rifle makes for a relatively handy post-apocalyptic companion.
  • A surplus Czech military magazine for the vz. 58 assault rifle, which has been modified to only be capable of holding 10 rounds in place of its standard capacity of 30 cartridges.
  • An original surplus Czechoslovak magazine, constructed out of lightweight aluminum and made for use within vz. 58 pattern rifles and modern derivatives. Despite strongly resembling standard Kalashnikov magazines, this curved box magazine is unsuitable for insertion into AK patten mag wells due to changes made in its follower assembly to facilitate a last-round-hold-open feature within the vz. 58.
  • Samopal vz. 58 P
  • Samopal vz. 58 Ps
  • This lightweight and relatively svelte Cold War assault rifle was originally developed for use by the Czechoslovakian army, in place of the various licenced Kalashnikov rifles which were then prevalent around eastern Europe. Baring more than a passing resemblance to the AK-47, this weapon nevertheless features a completely different array of internals and possesses no interchangeable parts with its Russian counterpart. Making use of proprietary magazines and a 15.4 inch barrel, the vz. 58 was regarded by some to be the Kalashnikov’s lesser known superior. Likely reconstructed from a pre-1986 imported parts kit, or brought back from a 3rd world war zone, this particular weapon features a removable wood impregnated plastic buttstock and a 'P' suffixed designation, which both mark it as an original infantry model.
  • This lightweight and relatively svelte cold war assault rifle was originally developed for use by the Czechoslovak army, in place of the various licenced Kalashnikov rifles which were then prevalent around eastern Europe. Baring more than a passing resemblance to the AK-47, this weapon nevertheless features a completely different array of internals and possesses no interchangeable parts with its Russian counterpart. Making use of proprietary magazines and a 15.4 inch barrel, the VZ. 58 is regarded by some to be the Kalashnikov’s lesser known superior. Likely reconstructed from a pre-1986 imported parts kit, or brought back from a 3rd world war zone, this particular weapon features a removable side-folding buttstock and a 'V' suffixed designation, which both mark it as an original airborne or crew issued model.
  • vz. 58 10-round magazine
  • vz. 58 10-round magazines
  • vz. 58 30-round magazine
  • vz. 58 30-round magazines
  • vz. 58 Tactical Sporter
  • vz. 58 Tactical Sporters
  • vz. 58 combat rifle
  • vz. 58 combat rifles
  • vz. 58 tactical rifle
  • vz. 58 tactical rifles

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@dseguin dseguin merged commit 101cb61 into CleverRaven:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants