New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VZ. 58 7.62x39mm rifles #58933
VZ. 58 7.62x39mm rifles #58933
Conversation
fixing some merge related issues.
Fixes merge related issues.
@anothersimulacrum, with regards to the VZ. 58 V, the reason why I made it be its own thing was to create a distinction between it and the regularly issued gun, as they were two different firearms used for two different tasks. Though, I suppose that since the whole variants system exists for a situation just like this, it only makes sense to utilise it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just grammar fixes, as @anothersimulacrum already got the variant comment I was going to make.
Czechoslovak
is only three letters from the fullCzechoslovakian
- vz. 58 isn't supposed to be capitalized(I'd keep it caps for the generic name)
~Your first link from Atlantic Firearms - Cold War
Example of fix below, just apply to the others.
- No stripper clips?
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
@TheShadowFerret, Thanks as ever for the changes to the grammar and things of that nature, surprisingly difficult to catch those mistakenly uncapitalized/ capitalised letters when working with a screen reader. Now, few things here. |
I think a variant is reasonable for the magazine names, fwiw. |
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
…58 V a variant of the .58 P, with appropriate mod groups, adds the guns and magazines to the generic guns migration lists, makes mods default rather than built in.
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
Just want mention, that the 58 is actually a bit more important in the name than the "vz." the "Sa vz.58" is short for "Samopal vzor 58" which can be translated as "Machine rifle model 58" so using vz as a name for the gun makes not much sense. |
@tinukedaya I didn’t consider that point when naming the rifle’s variants, though, thinking about it, there is no reason why “58” shouldn’t be in the name to begin with. So, I’ll likely go through and just rename the rifles to the, “vz. 58 combat rifle,“ rather than just the, “VZ combat rifle,” cause as you said, the way it's named currently doesn't make much sense. |
…y itself didn’t make sense from a taxonomy point of view. Also removes the magazine variants, as the distinction is no longer needed.
… into VZ58 fixes some git related merge errors.
…, after they were accidentally deleted.
@DoctorBoomstick: Not a Czech or Slovak native speaker but I'm almost certain "vz. 58" is parallel to Polish "wz 44", i.e. the letters stand for "wzór" (design) and are followed by the year the weapon was designed in. I know the pattern stands for both guns and bayonets. |
… tactical rifle,” to maintain consistency between rifle and magazine names.
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Summary
Content "adds the 7.62x39mm VZ. 58 P, VZ. 58 V, and VZ. 58 Tactical Sporter to the game."
Purpose of change
there was no real purpose for adding these guns, save for the fact that I do happen to be quite partial to a fine Czech VZ carbine, and wanted it to be in the game. Also, the Tactical Sporter is relatively common in the real world, with actual VZ originals being some what present in the US as well in the form of imports. Apart for that, this PR just aims at expanding the list of 7.62x39mm rifles, because one just can’t ever have enough guns when the Blob comes knocking.
Describe the solution
I have added, in no particular order, the VZ. 58 P, 58 V, and 58 Tactical Sporter rifles to the game, as well as their associated item spawns and magazines.
The VZ. 58 P is a standard automatic rifle that uses proprietary magazines. It is, in game terms, functionally the same as an AKM, save for being shorter, lighter, and overall smaller. The V model has a buttstock built into it, whilst the Tactical Sporter has a buttstock, muzzle break, and side rail.
Describe alternatives you've considered
possibly adding the IWI Galil rifle and associated variants first.
Testing
spawned in with each rifle and a collection of magazines, and went through systematically firing rounds off with each weapon, and testing the associated gun mods.
Additional context
VZ 58 Tactical 762x39mm - AtlanticFirearms.com
http://www.theballisticassistant.com/vz-58-purchase-the-parts-kit-and-receiver/
https://www.thetruthaboutguns.com/gun-review-czech-vzor-58/
https://www.youtube.com/watch?v=iCqElIDUzeI