Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] building with dino dung #58970

Merged
merged 11 commits into from Jul 5, 2022
Merged

[DinoMod] building with dino dung #58970

merged 11 commits into from Jul 5, 2022

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Jul 4, 2022

Summary

Mods "[DinoMod] building with dino dung"

Purpose of change

Feature parity with main game

Describe the solution

Adds dino feces as a potential ingredient for building soft_adobe_brick, create new requirements group for wattle and daub construction, add dino feces as an ingredient to that in the mod. Document that construction recipes can't be modded.

Describe alternatives you've considered

Force players to live in something besides dino dung. Mod the construction recipe directly from within the mod, but not supported

Testing

Game loads no errors with and without DinoMod enabled. Recipes as expected both ways

Additional context

"Bit sad that dino poop can't be used but eh" -Sathra on Discord

@LyleSY LyleSY added this to Doing in DinoMod via automation Jul 4, 2022
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 4, 2022
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Jul 4, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 4, 2022
@Sathra225
Copy link
Contributor

Ah, a constructive use for the vast amounts of dino waste lying around.
Yes, I did do that.

@LyleSY LyleSY marked this pull request as ready for review July 5, 2022 11:15
@dseguin dseguin merged commit 0e73ae5 into CleverRaven:master Jul 5, 2022
DinoMod automation moved this from Doing to Done Jul 5, 2022
@LyleSY LyleSY deleted the dino_dung_house branch July 5, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding
Projects
DinoMod
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants