Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gunmod slot audit on wooden stock longguns #59028

Merged
merged 1 commit into from Aug 15, 2022

Conversation

TheShadowFerret
Copy link
Contributor

@TheShadowFerret TheShadowFerret commented Jul 7, 2022

Summary

Bugfixes "Wooden stock longguns require mounts to use gunmods"

Purpose of change

Stocks were strangely mostly left alone when gunmod mounts were added, allowing single-piece wooden stocks that generally only interchange with the same rifle family to be replaced for folders and adjustable stocks without modifications. Also, #58936 can't be used on all guns that it should.

Describe the solution

Move over wooden stocked longguns to use stock mounts, in addition to checking if the RL gun has a mounting system by default for those modslots.

Describe alternatives you've considered

Taking away less modslots on the guns by only looking at the stock, but I am mean thorough so I won't :D

Testing

Bubba'd precious historical firearms

Additional context

Increased difficulty of getting tacticool weapon setups is noted, but now that nested_guns.json exists for every gun available it is much easier to now add a rare chance for someone to have already modified the gun to have mounts on it.

I left sights alone if the weapon is drilled for ring mounts or has any form of native mounting.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves <Bugfix> This is a fix for a bug (or closes open issue) labels Jul 7, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 7, 2022
@TheShadowFerret TheShadowFerret force-pushed the MoarWood branch 3 times, most recently from c3e877c to 812d1c3 Compare July 8, 2022 22:52
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 8, 2022
@TheShadowFerret TheShadowFerret marked this pull request as ready for review July 8, 2022 23:49
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 11, 2022
Tavor TS12 is not made of wood!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants