Update Aftershock UPS #59751
Closed
Update Aftershock UPS #59751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aftershock UPS was still using the old battery system. Now uses the new batteries. Updated flags as appropriate. Removed mention to batteries not being removable since that is no longer true.
Szara-ManOfHonor
requested review from
Maleclypse,
John-Candlebury and
Mom-Bun
as code owners
github-actions
bot
added
[JSON]
|
I believe if you change it to magazine instead of magazine_well, the volume will increase as intended. |
|
Aftershocks UPS is deliberatedly meant to work as it currently works #37331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Update Aftershock UPS to new battery system."
Purpose of change
Update the Aftershock UPS so it isn't using the outdated battery system.
Describe the solution
Set UPS to use the new batteries. Updated flags as appropriate. Removed mention to batteries not being removable since that is no longer true. Also added an arbitrary max encumbrance so the game doesn't clam it has a maximum of 80002 encumbrance. Encumbrance does not increase with a battery installed, unfortunately.
Describe alternatives you've considered
Closing my eyes and ignoring it.
Testing
Loaded up a character, spawned in a UPS, wore it, reloaded it. UPS functions.
Additional context
Would like to have encumbrance increase with a larger battery installed, but decided that I don't value glaring at my monitor enough to justify spending more time trying to make it work.