Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rare itemgroup extension from Aftershock #59840

Merged
merged 1 commit into from Aug 3, 2022
Merged

Remove rare itemgroup extension from Aftershock #59840

merged 1 commit into from Aug 3, 2022

Conversation

John-Candlebury
Copy link
Member

Summary

None

Purpose of change

The rare item group has been removed from vanilla, so it doesn't make sense to keep the extension in aftershock.

All the items contained in the group already spawn elsewhere.

Testing

Load game

@John-Candlebury John-Candlebury changed the title Remove rare itemgrou extension from Aftershock Remove rare itemgroup extension from Aftershock Aug 3, 2022
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 3, 2022
@ZhilkinSerg ZhilkinSerg merged commit 71937aa into CleverRaven:master Aug 3, 2022
@John-Candlebury John-Candlebury deleted the afs-remove-rare branch September 11, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse approved these changes

@Mom-Bun Mom-Bun Awaiting requested review from Mom-Bun

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@John-Candlebury @Maleclypse @ZhilkinSerg