Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchanted Tailoring Kit can repair nylon #60022

Merged
merged 1 commit into from Aug 13, 2022

Conversation

OtpalTS
Copy link
Contributor

@OtpalTS OtpalTS commented Aug 8, 2022

Summary

Bugfixes "Enchanted Tailoring kit can repair nylon"

Purpose of change

The normal tailoring kit has the ability to repair nylon (synthetic fabric), so I believe this to be just an oversight similar to it not being able to repair lycra some time ago( #47955 )

Describe the solution

Adding nylon to the things it can repair

Describe alternatives you've considered

Putting it off another day.

Testing

Loaded game and repaired + reinforced LBV using the enchanted tailoring kit

Additional context

Had to close the previous one and fix my repository since it was showing previous commits. This one is hopefully fixed

@OtpalTS OtpalTS requested a review from KorGgenT as a code owner August 8, 2022 10:23
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 8, 2022
@Knut-Aage-Hofseth
Copy link
Contributor

Knut-Aage-Hofseth commented Aug 8, 2022

This looks like one of the inheritance issues. Where perhaps more is written into the mod definitions of the tool than is needed. mtailors_kit has the property "copy-from": "tailors_kit". Magiclysm has a tailors_kit override that adds "black_dragon_hide" and "demon_chitin" to the materials list, nylon is added there.

Is it possible to instead use "copy-from" and "extend" to inherit the materials list from vanilla and just add the hide and chitin to the list? This will make sure that it is in line with vanilla on further updates there.

Possible issue is that the move cost for the use action is different between the mtailors_kit and the tailors_kit. I do not know if this is intended or an artifact of a change not being carried over to the mod.

I will have a look at this tonight myself if no one else steps in.

@OtpalTS
Copy link
Contributor Author

OtpalTS commented Aug 8, 2022

The issue is that it's pulling the materials from the vanilla tailor kit not the overwritten magiclysm tailors kit, otherwise one could just delete the materials on the mtailors_kit. If someone knows how to change that it would be great, but I'm very limited in what i know how to do.

@OtpalTS
Copy link
Contributor Author

OtpalTS commented Aug 9, 2022

Can someone explain why that test is failing and how I can fix it?

@anothersimulacrum
Copy link
Contributor

@catdach
Copy link
Contributor

catdach commented Aug 11, 2022

Is it possible to instead use "copy-from" and "extend" to inherit the materials list from vanilla and just add the hide and chitin to the list?

AFAIK "copy-from" and "extend" aren't able to get to and modify an array within a nested JSON object, that is within another array of another JSON object. Let me know if I'm wrong, my life would become a whole lot easier.

@dseguin dseguin merged commit b954575 into CleverRaven:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants