Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A dragons dream ... and achievement #60265

Merged
merged 2 commits into from Aug 18, 2022

Conversation

Stadler76
Copy link
Contributor

@Stadler76 Stadler76 commented Aug 17, 2022

Summary

Mods "A dragons dream ... and achievement"

Purpose of change

Adds an achievement for crossing black dragon threshold and dreams for all stages of black dragon mutation.

Describe the solution

Describe alternatives you've considered

None!

Testing

Tested the achievement with a new character (took me ~1.5 hours to find out, that new achievements don't work on old saves...)
and the dreams with a human slowly becoming a black dragon.

Additional context

Black Dragon achievement popup
If you don't get the joke, replace 'dragons' with 'Chuck Norris'.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions labels Aug 17, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 18, 2022
@sonphantrung
Copy link
Contributor

I have a question unrelated to the PR: How did you able to request review?

@Stadler76
Copy link
Contributor Author

Stadler76 commented Aug 18, 2022

I have a question unrelated to the PR: How did you able to request review?

I'm not able to. Requesting review from KorGenT happens automatically because he's the maintainer of Magiclysm.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 18, 2022
@dseguin dseguin merged commit 4c7b441 into CleverRaven:master Aug 18, 2022
@Stadler76 Stadler76 deleted the dragon-achievment-and-dreams branch August 18, 2022 05:25
Hirmuolio pushed a commit to Hirmuolio/Cataclysm-DDA that referenced this pull request Aug 27, 2022
* A dragons dream ... and achievement

* Fix JSON style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants