Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kevlar nape protector and counterweight pouch not spawning. #60286

Merged
merged 3 commits into from Aug 26, 2022
Merged

Fix kevlar nape protector and counterweight pouch not spawning. #60286

merged 3 commits into from Aug 26, 2022

Conversation

Marcos6226
Copy link
Contributor

@Marcos6226 Marcos6226 commented Aug 18, 2022 •
edited

Summary

Bugfixes "Make some headgear attachments have a chance to spawn."

Purpose of change

This PR should fix #60220

How to reproduce and see if the bug is fixed:
1- Open the debug menu.
2- Go to Test item group menu.
3- Select Military spawn group.

Describe the solution

I made the kevlar_nape_protector and counterweight_pouch have a slight (5%) chance of spawning in the military.json item group.
I also added a underline _ to counterweight pouch because I think it would cause issues if it was only separated by a space.

Describe alternatives you've considered

I'm open to any suggestions. Also if you know a better way to make the spawn, please let me know. I'll be very grateful.

Testing

Everything is working as intended.

Additional context

None

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing Spawn Creatures, items, vehicles, locations appearing on map <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 18, 2022
@Fris0uman Fris0uman merged commit fcf5ae1 into CleverRaven:master Aug 26, 2022
@Marcos6226 Marcos6226 deleted the several-bugfixes branch August 26, 2022 13:44
Hirmuolio pushed a commit to Hirmuolio/Cataclysm-DDA that referenced this pull request Aug 27, 2022
@Marcos6226 @Hirmuolio
Fix kevlar nape protector and counterweight pouch not spawning. (Clev…
2d20ec3 
…erRaven#60286)

* added a underline to counterweight pouch

* Adds several headgears attachments
@Termineitor244
Copy link
Contributor

Thanks, the spawns should have slipped me by when I was adding the rest of the spawns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fris0uman Fris0uman Fris0uman left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kevlar Nape Protector Can't Spawn
3 participants
@Marcos6226 @Termineitor244 @Fris0uman