Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLIND_EASY and BLIND_HARD flags work with no primary skill crafts #61179

Merged
merged 1 commit into from Oct 15, 2022

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented Sep 21, 2022

Summary

None

Purpose of change

Make crafting flags BLIND_EASY and BLIND_HARD work when no primary skill exists for the craft.
Fix #61178

Describe the solution

Checked whether a primary skill existed before applying BLIND_EASY and BLIND_HARD penalties to crafting. This causes BLIND_EASY crafting to be done without penalties in darkness, and BLIND_HARD crafting to take an arbitrarily selected twice as long when no primary skill exists.
Without this change BLIND_EASY would always be penalized for being two levels lacking of full speed, and BLIND_HARD being impossible for not being at least two levels above the required non existent level.

Describe alternatives you've considered

Write in some obscure documentation that when these flags are applied a primary skill always have to be present as well, and not be surprised that the documentation has been neither read nor followed.

Testing

Modified the two fire drill "recharging" recipes to be BLIND_EASY and BLIND_HARD respectively. Verified that the BLIND_EASY recipe took 4 minutes and the BLIND_HARD one 8 minutes in darkness at a 50% crafting rate.
Be confused by the reduced rate and checking them in daytime to see them at a 50% penalty there as well, and then check some arbitrary recent crafting, and see the 50% penalty was a base state of the character, not a result of the recipes themselves.

Additional context

#61177 could be changed to use the BLIND_HARD flag, but probably not before this PR has been merged, as setting this flag before that would not fix the inability to recharge the tools until this PR has been merged.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 21, 2022
@ZhilkinSerg ZhilkinSerg merged commit 110560d into CleverRaven:master Oct 15, 2022
@PatrikLundell PatrikLundell deleted the blind_crafting branch October 15, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JSON crafting flags "BLIND_EASY" and "BLIND_HARD" seem to be bugged
2 participants