Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with dialog tags in EOC #61314

Merged
merged 8 commits into from Sep 28, 2022
Merged

Fix issue with dialog tags in EOC #61314

merged 8 commits into from Sep 28, 2022

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Sep 27, 2022

Summary

None

Purpose of change

Fixes #61188

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 27, 2022
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Sep 27, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 27, 2022
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Sep 27, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 27, 2022
@pshepjr
Copy link
Contributor

pshepjr commented Sep 27, 2022

Thanks for this!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 27, 2022
@dseguin dseguin merged commit 1467cc6 into CleverRaven:master Sep 28, 2022
@Ramza13 Ramza13 deleted the dialog_fix branch September 28, 2022 20:24
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
@Ramza13 @captainego
Fix issue with dialog tags in EOC (CleverRaven#61314)
a560e14 
* First

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
@Ramza13 @captainego
Fix issue with dialog tags in EOC (CleverRaven#61314)
33eb7b4 
* First

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp
sparr pushed a commit to sparr/Cataclysm-DDA that referenced this pull request Dec 10, 2022
@Ramza13 @sparr
Fix issue with dialog tags in EOC (CleverRaven#61314)
6f2ad54 
* First

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp

* Update npctalk.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when using a variable name string in EOC dialogue
3 participants
@Ramza13 @pshepjr @dseguin