Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to deactivate extended bionics when NPC is requesting it #61412

Merged
merged 1 commit into from Oct 4, 2022
Merged

Offer to deactivate extended bionics when NPC is requesting it #61412

merged 1 commit into from Oct 4, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Offer to deactivate extended bionics when NPC is requesting it"

Purpose of change

Currently if player is wielding extended bionic weapon such as monomolecular blade or bionic claws, there is no way to put it down (= retract it) like any other weapon when NPC is requesting it. This PR adds an option to retract extended bionic weapon (if player has enough power to do it) on NPC request.

Describe the solution

  • Added check whether player can deactivate extended bionic weapon when NPC is requesting putting down player character's weapon.
  • If check is passed, add an option to deactivate the bionic weapon (= retract it) in dialogue with NPC.

Describe alternatives you've considered

None.

Testing

Got monomolecular blade, installed and activated it. Debug-spawned NPC which requests me to put down my weapon. Checked if there's an option to put down my weapon when I have enough bionic power and when I don't have it.

Additional context

None.

@Night-Pryanik Night-Pryanik added NPC / Factions NPCs, AI, Speech, Factions, Ownership Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` labels Oct 2, 2022
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 2, 2022
@dseguin dseguin merged commit 5ce6671 into CleverRaven:master Oct 4, 2022
@Night-Pryanik Night-Pryanik deleted the offer-deactivating-bionics-on-npc-request branch October 4, 2022 06:05
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants