Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swords looks_like fix #61517

Merged

Conversation

nopenoperson
Copy link
Contributor

@nopenoperson nopenoperson commented Oct 7, 2022

Summary

None

Purpose of change

many swords in swords_and_blades.json have no tiles, this will let most of them have tiles

Describe the solution

added looks_like to a bunch of swords that every other quality of the same sword copy from.

Describe alternatives you've considered

adding "looks_like": "kukri" to the falx, not adding "looks_like": "scimitar" to the kreigsmesser (im 99% sure msx would use the scimitar tile), letting someone else do it

Testing

some

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 7, 2022
@Fris0uman
Copy link
Contributor

More looks_like is always a good idea

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 8, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit 64e17c6 into CleverRaven:master Oct 8, 2022
@nopenoperson nopenoperson deleted the nopenoperson-swordslookslike branch October 21, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants