Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values of Football Helmet #61752

Merged
merged 2 commits into from Oct 26, 2022
Merged

Update values of Football Helmet #61752

merged 2 commits into from Oct 26, 2022

Conversation

multipiun
Copy link
Contributor

@multipiun multipiun commented Oct 17, 2022

Summary

Content "Update Armor values of Football Helmet"

Purpose of change

Breathability values on mouth and eyes body parts were not set for this helmet. Making it hard to lose moisture from those parts

Describe the solution

Assuming it's a Helmet with a visor I updated breathability values to be more sensible.

Describe alternatives you've considered

Creating 2 Differing helmets , one with visor protection and another variant without it

Testing

Additional context

None

Breathability values on mouth and eyes body parts were not set for this helmet. Assuming it's a Helmet with a visor , I updated breathability values to be more sensible.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 17, 2022
@bombasticSlacks
Copy link
Contributor

your summary needs to look like:

Content "Update Armor values of Football Helmet"

Exactly

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 18, 2022
@Fris0uman Fris0uman merged commit 147efdd into CleverRaven:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants