Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more disassembly recipes & Size cleanup #61868

Merged
merged 10 commits into from Oct 26, 2022

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Oct 22, 2022

Summary

Balance "A few more disassembly recipes and item size alterations"

Purpose of change

More ways to obtain resources. And more uses for some of this trash (I'm looking at you tea box). Also, some of these items had sizes wildly off what they should have been.

Describe the solution

The following items have had their sizes adjusted and were given a disassembly recipe

  • Jerrycan
  • Pliers
  • Locking pliers
  • Teapot
  • Pizza cutter
  • Cigar cutter

Also, the box of tea bags was given a disassembly recipe. It annoyed the hell out of me not being to take it apart for cardboard.

Describe alternatives you've considered

Testing

Additional context

The sizes were taken from Amazon products fitting the item's description. Pliers were a 6'' slip-joint plier model and Locking pliers were a 7'' locking plier model. An exception here is the teapot. Amazon only had one fitting steel teapot and the description didn't add up to the given package dimensions or weight. So I used some British website instead, which expectedly had accurate information about teapots.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Containers Things that hold other things astyled astyled PR, label is assigned by github actions Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions labels Oct 22, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 22, 2022
@Zireael07
Copy link
Contributor

Confused - how does one disassemble a jerrycan IRL? I think you can only cut it apart (i.e. butcher)

@Karol1223
Copy link
Contributor Author

Confused - how does one disassemble a jerrycan IRL? I think you can only cut it apart (i.e. butcher)

Correct, cutting it apart. But well, you can't butcher a jerrycan made of steel. So it needed a disassembly that uses a hacksaw. And here it is.

@Zireael07
Copy link
Contributor

You can 'B'utcher things like televisions for instance, so imho this should be under 'B' not worked around with disassembly.

@Karol1223
Copy link
Contributor Author

Karol1223 commented Oct 23, 2022

You can 'B'utcher things like televisions for instance, so imho this should be under 'B' not worked around with disassembly.

The TV's can be butchered because their material is part plastic. I do agree that this should probably be under cutting apart but cutting is so ungodly simple code-wise right now that its simply not plausible. Cutting cannot differentiate between cutting tool quality, it just needs any tool with said quality. Which roughly translates to you can cut apart a 2x4 into splinters with a kitchen knife in 6 seconds. This needs cleanup in itself, the time it takes and tool quality should depend on volume or mass of the item and perhaps different materials should need different quality (would open up the possibility of metal sawing being used to Butcher metal items) but as it stands its simply not feasible.

Also, what I think is important here, disassemblies are also under 'B' menu. It's not all that different.

@Fris0uman Fris0uman merged commit 5493981 into CleverRaven:master Oct 26, 2022
@Karol1223 Karol1223 deleted the recycling branch November 26, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants