Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1 tile radius to store ebook to device #62055

Merged
merged 3 commits into from Nov 4, 2022

Conversation

tivec
Copy link
Contributor

@tivec tivec commented Nov 2, 2022

Summary

Features "Allow ebook storage from books in adjacent tiles"

Purpose of change

Storing books in your smartphone or similar device is great, but i always got a bit annoyed that you have to pick up the ones you should store. Why can't I take a book directly out of the bookcase and flip through the pages while taking photos?

Describe the solution

This adds two variants to titled_filter_menu that allow for a radius to be passed. It is currently used by the iuse method ebooksave, but can be adapted to other usages.

Describe alternatives you've considered

Pain and suffering having to pick up my books all the time?

Testing

Tested with books in hand, on ground, in furniture, and in vehicles.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions labels Nov 2, 2022
@NetSysFire NetSysFire added the Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA label Nov 2, 2022
@mqrause
Copy link
Contributor

mqrause commented Nov 2, 2022

It's probably fine to use PICKUP_RADIUS (=6) instead of the radius of 1 for stuff like this.
And just personal preference, but you could add the radius as a parameter with a default value of -1 instead of adding overloads.

@tivec
Copy link
Contributor Author

tivec commented Nov 2, 2022

It's probably fine to use PICKUP_RADIUS (=6) instead of the radius of 1 for stuff like this. And just personal preference, but you could add the radius as a parameter with a default value of -1 instead of adding overloads.

I feel maybe PICKUP_RADIUS is a bit much (if it is 6) since you're not actually picking up the book to scan it. Edit: But I'll use it :)

For default parameter, I wanted to keep the position of radius relevant to the avatar, and not the messages, which would block default values. However, I see that the inv_internal method has the position just before none_message, so I'll make it a default value parameter to the original method.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 2, 2022
@tivec
Copy link
Contributor Author

tivec commented Nov 2, 2022

Not entirely happy with having to change other implementations to use -1 for range (which would have been default anyway) when they use a none_message, but there's really no other option.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Nov 3, 2022
@dseguin dseguin merged commit 5fd21bf into CleverRaven:master Nov 4, 2022
@tivec tivec deleted the store-adjacent-books branch November 4, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants