Rewrite crafting skill checks to use normal roll

[anothersimulacrum]

Summary

SUMMARY: Features "Tweak crafting failure formulas and display failure chances"

Purpose of change

See #46153 for maximal detail, this replaces that.
The goals of this are two-fold:

1. Make calculating failure chance at all reasonable
2. By making failure chance calculation possible, enable tweaking and testing of the crafting failure formula

There are also longer-term goals such as #44738, and enabling partial skill to play a role.

Describe the solution

From @I-am-Erk 's rewrite of the formula:

1. NPCs no longer have to be more skilled than you to increase your chance of success. Instead, each NPC able to help that also has all the prerequisites to be able to do the craft on their own gets a skill check just like you. Then we add those skill checks together using the formula:

final skill value = sqrt( your skill value^2 + sum (all contributing NPC skill values^2) )

This root-sum-of-squares is the same system used in summing morale: it creates diminishing returns the more contributors you have, and makes more skilled sources of help substantially outweigh smaller ones. Using this formula, for example, if you and a helper NPC both have an effective skill level of 7 once all effects are applied, your combined skill level is around 10. If you add another NPC of effective skill level 7, you get a total combined skill of 12.

In the end this makes NPC helpers much more useful (previously they just added a small flat bonus, and only if they were more skilled than you).

2. Changes the role of secondary and primary skills in your check, making secondary skills potentially more important. Previously the weight of primary and secondary skill requirements was flat: 3/4 of your skill check was from your primary skill and 1/4 was from the average of the secondary skills. Now it is a weighted average of: 2*primary skill*required level of primary skill, + sum of secondary skills * required level of secondary skills. That means if a recipe asks for electronics 2 and cooking 1 (what the hell recipe is this??), your overall level in electronics will be twice as important to your final skill value. If that same recipe uses fabrication 2 as its primary skill, then fabrication will weigh in at 2x as important as electronics and 4x as important as cooking.

3. Moves the method of calculating your effective skill level to a new method to make it easier to determine your and your NPCs' effective skills with all modifiers included.

From my additional changes:

4. Calculate and display the failure chance for a recipe 9f2ee4d

5. Adjust the chance for destruction of components to follow a different formula 58f5676, and display that chance (catastrophic failure chance). This is just an easier version of the above formula for now, I just fudged it to get pretty numbers.

6. Add some tests to:

   1. generate failure chance for every recipe in the game for some given stats related to the recipes
   2. Check if the actual failure rate of a number of recipes matches the calculated value, and that both match a value input, to detect changes to the failure rates.

Testing

See tests.




(Ridiculous percentages due to debug set skills command)

Additional context

This has ping-ponged between Erk and I for a while, and the commit history reflects that. Mergers may want to avoid squashing for history reasons.
I do not expect this to be the final formula(s), this just puts the infrastructure in place.
The proficiency info screen is lying about how the failure rates work from proficiencies. I want to fix that (included in https://github.com/CleverRaven/Cataclysm-DDA/pull/46082/commits), but it's a lot of lines, and so I think it's better separate.
Closes #46153

[I-am-Erk]

thank you for this

[I-am-Erk]

we've done it Sim, we've destroyed one of the core parts of the game. Bwahahaha.

[andrei8l]

I get an assertion failure here

/usr/include/c++/12.2.1/bits/random.h:1995: std::normal_distribution<_RealType>::param_type::param_type(_RealType, _RealType) [with _RealType = double]: Assertion '_M_stddev > _RealType(0)' failed.

Build with -Wp,-D_GLIBCXX_ASSERTIONS and run cata_test proficiency_gain_short_crafts