New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bombastic Perks, Perk System Mod #64285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
JSON & C++ formatters
data/mods/BombasticPerks/perkmenu.json|256|
data/mods/BombasticPerks/perkmenu.json|270|
data/mods/BombasticPerks/perkmenu.json|275 col 1|
data/mods/BombasticPerks/perkmenu.json|276|
data/mods/BombasticPerks/perkmenu.json|281|
data/mods/BombasticPerks/perkmenu.json|295|
data/mods/BombasticPerks/perkmenu.json|300 col 1|
data/mods/BombasticPerks/perkmenu.json|301|
data/mods/BombasticPerks/perkmenu.json|306|
data/mods/BombasticPerks/perkmenu.json|320|
data/mods/BombasticPerks/perkmenu.json|324|
data/mods/BombasticPerks/perks.json|2|
data/mods/BombasticPerks/perks.json|16|
data/mods/BombasticPerks/perks.json|109|
data/mods/BombasticPerks/perks.json|121|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these perks also be gated by skill levels?
Requested perk: Iron Knuckles
"You've thrown hands so often your knucklebones have thickened up. You gain additional hand armor." (also has inherent bash damage so you effectively always have knuckles on)
Requires unarmed 2+
This is amazing work, thanks for implementing it. The only thing I can think of is that if the "dynamic_lines" of the perk granting options within perk menu could get their content from the perk mutation descriptions, that would great simplify mod maintenance. |
yeah, I'm going to have skill reqs and perhaps level reqs on them.
you can add any perks you want as additional once it gets added to mainline 😄
This is a good idea. I'll work on this before finishing the mod. |
d140844
to
1172a08
Compare
5189c4b
to
08c7c7b
Compare
08f268e
to
e5b1384
Compare
Co-Authored-By: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> Co-Authored-By: avianArsonist <91783002+avianArsonist@users.noreply.github.com>
d3df55a
to
639f2ee
Compare
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Summary
Mods "New mod where the player unlocks perks"
Purpose of change
Adds a new mod similar to stats through kill that gives the player perk points to spend on getting enough EXP
Describe the solution
relies on #64426 for triggering level ups.
Adds EOC to open up a perk menu dialogue, which lets you select perks if you have available perk points.
Describe alternatives you've considered
Testing
Everything works in game
Additional context