Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bombastic Perks, Perk System Mod #64285

Merged
merged 9 commits into from Mar 31, 2023

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Mar 16, 2023

Summary

Mods "New mod where the player unlocks perks"

Purpose of change

Adds a new mod similar to stats through kill that gives the player perk points to spend on getting enough EXP

Describe the solution

relies on #64426 for triggering level ups.

Adds EOC to open up a perk menu dialogue, which lets you select perks if you have available perk points.

Describe alternatives you've considered

Testing

Everything works in game

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mechanics: Enchantments / Spells Enchantments and spells Mods Issues related to mods or modding labels Mar 16, 2023
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/items.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/items.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 16, 2023
Copy link
Contributor

@TheShadowFerret TheShadowFerret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these perks also be gated by skill levels?

Requested perk: Iron Knuckles

"You've thrown hands so often your knucklebones have thickened up. You gain additional hand armor." (also has inherent bash damage so you effectively always have knuckles on)
Requires unarmed 2+

data/mods/BombasticPerks/items.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
@John-Candlebury
Copy link
Member

This is amazing work, thanks for implementing it.

The only thing I can think of is that if the "dynamic_lines" of the perk granting options within perk menu could get their content from the perk mutation descriptions, that would great simplify mod maintenance.

@bombasticSlacks
Copy link
Contributor Author

bombasticSlacks commented Mar 16, 2023

Can these perks also be gated by skill levels?

yeah, I'm going to have skill reqs and perhaps level reqs on them.

Requested perk: Iron Knuckles

you can add any perks you want as additional once it gets added to mainline 😄

The only thing I can think of is that if the "dynamic_lines" of the perk granting options within perk menu could get their content from the perk mutation descriptions, that would great simplify mod maintenance.

This is a good idea. I'll work on this before finishing the mod.

data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
@bombasticSlacks bombasticSlacks marked this pull request as ready for review March 25, 2023 19:13
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 26, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 26, 2023
bombasticSlacks and others added 3 commits March 30, 2023 09:16
Co-Authored-By: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
Co-Authored-By: avianArsonist <91783002+avianArsonist@users.noreply.github.com>
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 30, 2023
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Ever since the apocalyse you get a funny feeling during storms and have trouble trusting small appliances. You usually have a pretty good idea where they are though.
  • No work, no social obligations, lots of time to focus on your hobies. You feel like you've been picking up skills faster recently.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/eocs.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perkmenu.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 30, 2023
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 30, 2023
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
data/mods/BombasticPerks/perks.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 30, 2023
@dseguin dseguin merged commit 31e2f3c into CleverRaven:master Mar 31, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants