Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More scrollbars #65767

Merged
merged 2 commits into from
May 22, 2023
Merged

More scrollbars #65767

merged 2 commits into from
May 22, 2023

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented May 20, 2023

Summary

None

Purpose of change

Describe the solution

Split the trait description into lines and allow scrolling with < and >.

Describe alternatives you've considered

Testing

Viewing a long trait description in the character info screen:

char_menu

Viewing a long trait description in the mutation screen:

Screenshot from 2023-05-20 17-41-07

Additional context

Also fixed a small unrelated issue where entering "examine" mode in the mutation menu would display a blank description box until the user selects a different trait.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 20, 2023
@bombasticSlacks bombasticSlacks merged commit e1fad37 into CleverRaven:master May 22, 2023
22 of 26 checks passed
@dseguin dseguin deleted the more_scrollbars branch May 24, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some UI parts has lack of scroll bar
2 participants