more space for Iteminfo #6871
Merged
more space for Iteminfo #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/item.cpp
| @@ -462,8 +462,8 @@ void item::load_info(std::string data) | |||
| if (is_food()) { | |||
| it_comest* food = dynamic_cast<it_comest*>(type); | |||
|
|
|||
| dump->push_back(iteminfo("FOOD", _("Nutrition: "), "", food->nutr)); | |||
| dump->push_back(iteminfo("FOOD", _("Quench: "), "", food->quench)); | |||
| dump->push_back(iteminfo("FOOD", _("Nutrition: "), "", food->nutr, true, "", false, true)); | |||
There was a problem hiding this comment.
If you need to pad between elements (which seems like a good idea), I think that's what argument 6 is for. I don't like the idea of inserting padding into the translated strings, and it has caused problems before.
Sorry it took so long to give feedback on this, things have been very busy.
There was a problem hiding this comment.
argument 6 is stored in sPlus and used as additional string betewen the translated string and the value. As far I found this parameter is only used for ammo informations
|
Adding Comment to correct PR update time @kevingranade I removed the padding from the translated strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redone #6212, while leaving space for other UI elements (#6274)
FIXES #6701, #6700