Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fungal Insects & fungal zombie fixes. #70039

Merged
merged 13 commits into from
Dec 13, 2023

Conversation

zdlpoppa
Copy link
Contributor

@zdlpoppa zdlpoppa commented Dec 7, 2023

Summary

Content "Add's more fungal insect monsters, fixes bugs I forgot in last PR."

Purpose of change

Always wanted to see some annoying fungal wasps to mess with players more; Decided to combine this PR with a quick bugfix PR for some mistakes I missed.

Describe the solution

Adds more monsters. Saw I missed some evolutions and butcher changes, which will be changed by this PR.

Describe alternatives you've considered

Not adding fungal wasps and bees.

Testing

None yet.

Additional context

Feedback on what should have fungal variants and how I should scale their stats should be appreciated, because I'm mostly going off of just lowering their base stats. (also, a possible addition of fungal flesh only consumable by specific monsters/mutations, I.E triffids, or ants, and the mycus/rat? mutations.)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Dec 7, 2023
@ADekema
Copy link

ADekema commented Dec 7, 2023

A few thoughts:

  1. Why do the wasps have nobreath? They are still living creatures that need oxygen. Being parasiticed by fungus doesn't change that.
  2. Why are they still hard to shoot? This makes sense for normal gaint wasps who fly around but it doesn't for fungal wasps if they can't fly.
  3. Why do they get the poison flag? Every other fungalized creature keep thier original butchering results. Feral humans and other gaint insect are still edible when infected with Fungus.

@zdlpoppa
Copy link
Contributor Author

zdlpoppa commented Dec 7, 2023

A few thoughts:

  1. Why do the wasps have nobreath? They are still living creatures that need oxygen. Being parasiticed by fungus doesn't change that.
  2. Why are they still hard to shoot? This makes sense for normal gaint wasps who fly around but it doesn't for fungal wasps if they can't fly.
  3. Why do they get the poison flag? Every other fungalized creature keep thier original butchering results. Feral humans and other gaint insect are still edible when infected with Fungus.

1: anything infected by fungus as such is essentially dead, They aren't alive by their own volition. This can imply multiple organs stopping or being punctured, lungs collapsing, but still having the host move on the command of the infestation.
2: hard to shoot is something i'm looking to remove soon, a small oversight on my part.
3: similar to the fungus ant, it gains the poison flag as the flesh is fainted. Other ferals and insects being edible still could've been an oversight, although I may have to check

@ADekema
Copy link

ADekema commented Dec 7, 2023

1: anything infected by fungus as such is essentially dead, They aren't alive by their own volition. This can imply multiple organs stopping or being punctured, lungs collapsing, but still having the host move on the command of the infestation.
2: hard to shoot is something i'm looking to remove soon, a small oversight on my part.
3: similar to the fungus ant, it gains the poison flag as the flesh is fainted. Other ferals and insects being edible still could've been an oversight, although I may have to check

1: From what I know from the lore that isn´t the way the fungul infection works. It is mend to work like the real life Cordyceps fungus. The fungal infection is a parasite that can crudely influence the host but the host still needs to have all of it´s vital functions intact. If it doesn´t breath than the host simply expires and unlike the blob the fungus can´t do anything about it. Also everyother fungal creature including the fungal ant still needs to breath.
3: Only the fungal ant seems to give tainted meat. It would seem to me that it is the ants that are the oversight not everyother fungal creature.

@Karol1223
Copy link
Contributor

Fungal infection absolutely does not kill the host in the... uh, traditional sense. Look at current fungalized feral humans. Something infected with the mycus doesn't suddenly become a zombie equivalent, so wasps becoming tainted and not needing to breathe does not make sense.

@fairyarmadillo
Copy link
Contributor

fairyarmadillo commented Dec 7, 2023

A few thoughts:

  1. Why do the wasps have nobreath? They are still living creatures that need oxygen. Being parasiticed by fungus doesn't change that.
  2. Why are they still hard to shoot? This makes sense for normal gaint wasps who fly around but it doesn't for fungal wasps if they can't fly.
  3. Why do they get the poison flag? Every other fungalized creature keep thier original butchering results. Feral humans and other gaint insect are still edible when infected with Fungus.

1: anything infected by fungus as such is essentially dead, They aren't alive by their own volition. This can imply multiple organs stopping or being punctured, lungs collapsing, but still having the host move on the command of the infestation. 2: hard to shoot is something i'm looking to remove soon, a small oversight on my part. 3: similar to the fungus ant, it gains the poison flag as the flesh is fainted. Other ferals and insects being edible still could've been an oversight, although I may have to check

This is incorrect. You're likely confused because fungal zombies exist. Fungal zombies are people who died and then became zombified, and only after that were they fungalized, so their flesh is still tainted and they still don't need to breathe, because that's how things worked before the Mycus got them. Insects can't zombify, so if they fungalize they need to do it while still being alive.

Fungal monsters probably should not be edible as the mycus itself is not normally edible, but that's a separate issue.

@zdlpoppa
Copy link
Contributor Author

zdlpoppa commented Dec 7, 2023

After seeing the comments, I do agree that having no_breathe on the wasps doesn't make much sense, but I do feel that any fungal infected monsters shouldn't have consumable flesh; eating regular mold is a horrible idea, mycus mold is even worse. Ideas are still completely on the table though.

@fairyarmadillo
Copy link
Contributor

fairyarmadillo commented Dec 7, 2023

After seeing the comments, I do agree that having no_breathe on the wasps doesn't make much sense, but I do feel that any fungal infected monsters shouldn't have consumable flesh; eating regular mold is a horrible idea, mycus mold is even worse. Ideas are still completely on the table though.

Your best options are

  1. Leave it as normal insect flesh for parity with existing monsters, and make a note in the PR that someone should get around to fixing this sometime
  2. Make a new type of meat called fungal_flesh which has a new flag similar to POISON that makes it cause injury and sickness if eaten, then make this meat poisonous to everyone except mutants who specialize in eating fungus. IMO this should be insect and plant, as ants farm mold to eat and plants love to eat food broken down by fungus.

2 is a tall order if you don't know C++. If you do 1, I'll be happy to add 2 to my short list of things to do in another PR.

@zdlpoppa
Copy link
Contributor Author

zdlpoppa commented Dec 8, 2023

After seeing the comments, I do agree that having no_breathe on the wasps doesn't make much sense, but I do feel that any fungal infected monsters shouldn't have consumable flesh; eating regular mold is a horrible idea, mycus mold is even worse. Ideas are still completely on the table though.

Your best options are

  1. Leave it as normal insect flesh for parity with existing monsters, and make a note in the PR that someone should get around to fixing this sometime
  2. Make a new type of meat called fungal_flesh which has a new flag similar to POISON that makes it cause injury and sickness if eaten, then make this meat poisonous to everyone except mutants who specialize in eating fungus. IMO this should be insect and plant, as ants farm mold to eat and plants love to eat food broken down by fungus.

2 is a tall order if you don't know C++. If you do 1, I'll be happy to add 2 to my short list of things to do in another PR.

2 is most definitely what I'd want to do, but I have no C++ coding ability, so option 1 is the one I have to go with currently. I do really like the idea of flesh only consumable to some due to it's fungal nature. I'll make a note of it!

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A gigantic wasp worker, It's body now a host for a plethora of mushrooms and spores. Her abdomen glows faintly with a blue light, each pulse bringing a new crack for fungal growths to excape from. It's stinger seems to have a soul of it's own, reaching out towards anything that isn't infested like itself.
  • A huge wasp the size of a large cat. It's bright yellow markings have faded and ripped to show a disqusting mass of mold and rot beneath. Her wings jut into extremely odd angles, making flight impossible. Even still, it chases anything without any sense of self-preservation.
  • A wasp worker which seems to move like a puppet on strings. It ambles backwards, its stinger, grotesquely swollen and pulsating, serving as a perverse compass guiding it forward, seeking relentlessly for something—anything—to pierce. It periodically contracts and then abruptly expands, ejecting a fine mist of spores into the surrounding air.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 8, 2023
@fairyarmadillo
Copy link
Contributor

2 is most definitely what I'd want to do, but I have no C++ coding ability, so option 1 is the one I have to go with currently. I do really like the idea of flesh only consumable to some due to it's fungal nature. I'll make a note of it!

If this gets merged I'll make it a priority to handle it on my end. Plant has a lot of trouble feeding itself and this seems like a solid way to go.

@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 8, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 8, 2023
@zdlpoppa zdlpoppa marked this pull request as ready for review December 9, 2023 06:51
@zdlpoppa zdlpoppa marked this pull request as draft December 9, 2023 07:43
@ADekema
Copy link

ADekema commented Dec 9, 2023

Hate to nage again but I just saw that the bleedrate of the wasps is 0. Doesn´t the same thing we went over with ¨fungal wasps need to breath becease still functional vitals and organs¨ also apply to the circulatory system? So fungal wasps should bleed just like normal wasps? Doesn´t the same also go for standart fungal zombies?

@zdlpoppa
Copy link
Contributor Author

zdlpoppa commented Dec 9, 2023

Hate to nage again but I just saw that the bleedrate of the wasps is 0. Doesn´t the same thing we went over with ¨fungal wasps need to breath becease still functional vitals and organs¨ also apply to the circulatory system? So fungal wasps should bleed just like normal wasps? Doesn´t the same also go for standart fungal zombies?

For now, yes they will bleed

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 9, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 10, 2023
@zdlpoppa zdlpoppa marked this pull request as ready for review December 10, 2023 04:13
@Maleclypse Maleclypse merged commit 3c95a24 into CleverRaven:master Dec 13, 2023
32 of 36 checks passed
@zdlpoppa zdlpoppa deleted the Fungal-Insects-And-Fixes branch December 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants