Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] Paraclesian's shouldn't have drivers license #72493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maleclypse
Copy link
Member

Summary

Mods "Prevent Paraclesians from being born with a drivers license"

Purpose of change

Limits Paraclesian hobbies to the Paraclesian birth hobby granting deduction.

Describe the solution

Use the hobbies field in professions.

Describe alternatives you've considered

None

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Xedra Evolved Anything to do with Xedra Evolved labels Mar 19, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 19, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 19, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 21, 2024
@Maleclypse
Copy link
Member Author

Note to self: Hommullus should have access to Birthmark hobbies that block other birthmarks but grant a special ability of minor usage. The Key, should unlock a door once a day.

Update data/mods/Xedra_Evolved/player/hobbies.json

Update hobbies.json

Arvore start

Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 21, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Apr 25, 2024
Copy link
Contributor

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing on missing traits

{
"type": "profession",
"subtype": "hobby",
"id": "ARVORE_ROOT_AND_SOIL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving the same ID to the trait and the profession might lead to confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants