Remove .40 from 610 #72639
Draft
Remove .40 from 610 #72639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
Code: Tests
|
Since you're touching the tests anyway, it would be nice if you'd switch the item constructors from strings to itype_ids. |
I dont know what that means |
|
It's fine then, you don't have to worry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Remove .40 from S&W 610"
Purpose of change
The 610 can fire 10mm and 40 S&W, but the cylinder is machined in such a way that it can fire 10mm without a moonclip, but not .40 S&W and so without a moonclip, it would just push the 40 S&W cartridge into the cylinder. As moonclips currently do not function with reload eject, Tonk suggested to remove .40 S&W from the 610 entirely.
Describe the solution
Removes .40 from 610, while you could still put 40 S&W in the speedloader I felt it would be confusing, which is also why any mentions of .40 was removed from the 610's description.
Describe alternatives you've considered
Testing
Tested locally, works fine.
Additional context
Currently in draft as I figure out how to fix the tests (why is so much of it relying on the 610 darn)