New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crowns the Mas .223 with the Obsoletion Hat #72659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Spawn
Creatures, items, vehicles, locations appearing on map
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 27, 2024
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Mar 28, 2024
Maleclypse
reviewed
Mar 31, 2024
Maleclypse
reviewed
Mar 31, 2024
fixe merge errors.
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
According to History of Weapons and War, as well as a great deal of other sources, the Mas .223, the semi-automatic version of the Famas F1 rifle, is an extremely rare gun, to put it lightly.
I would wager you would have a better chance of running across a Russian SVD than a true Famas or a Mas .223 within the reemits of New England, with a grand total of 1 Mas being present for auction on Gun Broker. This falls short of our base entry requirement by 99 entries, meaning that on today’s episode of Boomstick recreates Grey’s Anatomy on guns, our patient is the Mas .223.
Describe the solution
I have simply removed both the Mas 223, as well as its related 25-round magazine, which, surprisingly, didn’t have any actual spawn locations.
Describe alternatives you've considered
I looked high, I looked low, and I looked all across the globe for a suitable replacement for the Mas, but it turns out that French guns in the US are about as common as American assault rifles in France, perhaps even less. I wasn’t going to add unicorn cartridges for antique rifles, sorry .30 French Long, and my eyes glazed over at the thought of adding another 5.56mm black rifle.
Testing
It’s a simple one-step dance of removing the Mas and migrating it. That being said, I fully expect things to detonate.
Additional context