Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit spell UI word choice when using psionics #72676

Merged
merged 12 commits into from
Mar 29, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Mar 28, 2024

Summary

Mods "Edit spell UI word choice when using psionics"

Purpose of change

As part of my continuing effort to get people to stop talking about "psionic spells," change the UI slightly so that when using psionics it doesn't refer to "casting"

Describe the solution

When using psionics, change "casting time" to "channeling time," "casting cost" to "channeling cost," and specifically change the not-enough-juice message to "Not enough Stamina" instead of "Not enough energy"

Describe alternatives you've considered

Testing

Loaded up a game with Magiclysm/MoM/XE, got a bunch of powers from each mod. Magiclysm/XE still had casting time etc, MoM had channeling time.

Additional context

I don't need to change the generic "You cast %s" message because every MoM power has a unique message for that power.

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Mar 28, 2024
@github-actions github-actions bot requested a review from KorGgenT March 28, 2024 15:10
@github-actions github-actions bot added Mods Issues related to mods or modding json-styled JSON lint passed, label assigned by github actions labels Mar 28, 2024
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
src/magic.cpp Outdated Show resolved Hide resolved
Standing-Storm and others added 10 commits March 28, 2024 10:31
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Mar 28, 2024
@RedMisao
Copy link
Contributor

Could this be JSONized the same way as the "You cast %s" messages?
Just asking, I don't have anything in mind (lol) other than adding further customization to UI elements.

@Standing-Storm
Copy link
Contributor Author

Could this be JSONized the same way as the "You cast %s" messages? Just asking, I don't have anything in mind (lol) other than adding further customization to UI elements.

There's a desire to JSONize spellcasting parameters: #70506

I don't have the programming knowledge to do so, however.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 28, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 28, 2024
@Maleclypse Maleclypse merged commit 41d6a78 into CleverRaven:master Mar 29, 2024
26 checks passed
@Standing-Storm Standing-Storm deleted the nomenclature branch March 29, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants