Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Can't think, head hurts too much #72737

Merged
merged 4 commits into from Apr 4, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Mar 31, 2024

Summary

Mods "Too much pain shuts down your powers"

Purpose of change

I think the change I made to the success formula for psi was good, but it does lead to being able to use them in basically any situation, even ones that are a little hard to believe. Like if you have multiple broken limbs or if you're bleeding profusely from numerous wounds. Plus, this game is all about the death spiral and making sure to avoid situations where it could happen to you.

Describe the solution

Add an opens_spellbook event EoC that checks your pain and, if it's 40 or above, hits you with a instant-duration effect with the NO_PSIONICS flag, preventing you from using your powers. This is Distracting pain or higher.

That's pretty low, but it represents someone who's completely unused to concentrating under adverse circumstances. Therefore, the concentration proficiencies and relevant traits all raise this limit: the Improved Concentration and Prime Intelligence traits increase this limit by 15 (and Easily Distracted lowers it by 15), as does Basic Concentration. Expert Concentration increases it by an additional 30, and Master Concentration increases it by an additional 45, totaling 130 (+30 if you have both traits), well into Severe Pain territory before the pain disables your powers. The various pain-related mutations are not accounted for here because they already modify the amount of pain you receive and how fast you recover from pain.

Maintaining concentration on existing powers already has a system for dealing with pain (pain reduces intelligence, which reduces your concentration threshold), so it has not been touched.

Finally, I reduced the pain causes by psionic overload due to this (it was higher than necessary and a single instance would have turned off your powers), and I also realized that while it had a vomit_chance it did not have a vomit_tick, so it was checking for vomiting every second. I added "vomit_tick": [ 200 ], so it will now cause you to vomit 99.5% less than previously.

Describe alternatives you've considered

Testing

image

Everything works. Powers are disabled properly due to pain, proficiencies increase the pain limit, and the effect that disables powers only lasts a single round and can't be stacked by repeatedly opening and closing the spellbook.

Additional context

This doesn't affect your ability to cast spells, for extra inter-mod compatibility. That's why I PRed the NO_PSIONICS flag in the first place.

Though maybe I should change that message to say "You can't channel any of the powers you know!" when it's NO_PSIONICS disabling your powers.

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 31, 2024
@Maleclypse
Copy link
Member

Though maybe I should change that message to say "You can't channel any of the powers you know!" when it's NO_PSIONICS disabling your powers. I was going to ask. :)

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2024
@Nebnis
Copy link
Contributor

Nebnis commented Mar 31, 2024

This might not be necessary anymore because pain will hurt your int a lot harder now due to #72687 downscaling you to -10 at 100 pain

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Mar 31, 2024

This might not be necessary anymore because pain will hurt your int a lot harder now due to #72687 downscaling you to -10 at 100 pain

I made this after taking it into account: see the additional context in #72588 where I tested ludicrous amounts of pain when making that change.

@I-am-Erk I-am-Erk merged commit 18cd77d into CleverRaven:master Apr 4, 2024
23 of 24 checks passed
@Standing-Storm Standing-Storm deleted the too-much-pain-no-psi branch April 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants