Disallow some guns from turrets based on action #72789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
astyled
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
We are extremely permissive in which firearms we allow to be stuck in a turret mount (what even is a turret mount??). If we consider that the automated version of this is essentially a CROWS, many of these firearms don't make sense, either because they cannot be actuated by the turret controls (Slam fire, single-action revolvers, or lever actions), or because the firearms do not function when braced (inertia actions).
Describe the solution
Add "NO_TURRET" to relevant firearms.
Very generously assuming that sticking a tab or something to pull a pistol slide or work a pump slide.
Describe alternatives you've considered
Adding "NO_TURRET" to many, many, many more firearms.
Expanding this out to pump actions.
Getting gud at C++ and making turrets check if there's a turret mount(flag? mod slot?) on the firearm in question before allowing them to be mounted.
Testing
Loaded game, got debug hammer space, tried to install no-turreted firearms.
Additional context
None.