run IWYU for some files #72906
Merged
run IWYU for some files #72906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
kevingranade
reviewed
Apr 8, 2024
github-actions
bot
removed
the
BasicBuildPassed
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
IWYU changes are good.
Describe the solution
The first commit changes
#includes in selected files to comply with IWYU.#include <cxxabi.h>issue forgame.cpp. Including it broke the compilation. According to the issue, I deduced that IWYU would not require it in the new version.The second commit adds some includes to other files so that the project compiles.
sdltiles.cpp, where there are#ifdefs that confuse IWYU.Describe alternatives you've considered
Testing
Compiled locally on my Windows machine Visual Studio with tiles on.
Additional context
I remember there was some fiasco last time when #71141 and #71183 were merged in the same merge commit. I ask the reviewer to not include any other iwyu changes in their merge. Right now, there aren't any anyway.
I work on these files somewhere else and use IWYU to check that the files I changed have good includes. By making this PR, I improve my local noise ratio.