Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bombastic Perks] Add more perks #72940

Merged
merged 9 commits into from Apr 11, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Apr 9, 2024

Summary

Mods "[Bombastic Perks] Add more perks"

Purpose of change

Had yet more ideas for perks

Describe the solution

Add some perks:

  • Grit Your Teeth: Activate to reduce your current pain by 30 or by half (whichever is greater) for 3 minutes. When it ends, all previous pain returns. The cooldown is minutes equal to your pain at the time you used the perk. Requires Built Tough; cannot have Pain Sensitive or its upgrades
  • Undying Loyalty: If you take damage when your torso or head is at 50% health or lower, and you have any allies with you, all nearby allies take 20% less damage for 1 minute. Can trigger no more than once per 5 minutes. Requires Extrovert, cannot have the various predatory mind mutations (Pack Hunter is allowed)
  • Non-combatant: Hey, that's against the Geneva Convention! You take 25% less damage when not wielding a weapon. Requires Pacifist trait

And one playstyle perk:

  • Moonstruck: You are greatly affected by the phases of the moon. When the moon is full, you gain +3 to all stats. When the moon is waxing, you gain +1 to all stats, when the moon is waning, you gain no benefit, and during the new moon you suffer a -2 penalty to all stats. (done as a recurring EoC that rechecks the buff every hour)

More to come.

I also changed the enchant on Built Tough to ARMOR_ALL, since it explicitly says it's supposed to reduce all damage by 5%.

Describe alternatives you've considered

Testing

Tested perks, they all require appropriate prerequisites and all work properly.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft April 9, 2024 22:08
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mods: Bombastic Perks labels Apr 9, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @bombasticSlacks

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Must have the Built Tough perk./n/nMust not have the Pain Sensitive, Hyperalgesia, or Extreme Hyperalgesia Traits

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 10, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2024
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2024
@OtpalTS
Copy link
Contributor

OtpalTS commented Apr 10, 2024

Doesnt this mean that Non-combatant is a -15% damage reduction for unarmed?

@Standing-Storm
Copy link
Contributor Author

Doesnt this mean that Non-combatant is a -15% damage reduction for unarmed?

Yes. Since without mods unarmed does almost no damage anyway, I don't think it's particularly unbalanced.

@ashGlaw
Copy link
Contributor

ashGlaw commented Apr 10, 2024

Seems legit to me

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 11, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review April 11, 2024 03:50
@Maleclypse Maleclypse merged commit 9819962 into CleverRaven:master Apr 11, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the more-perks branch April 11, 2024 16:12
@EternalEmo
Copy link

Description for non-combatant is still 15% instead of 25%?

@Standing-Storm
Copy link
Contributor Author

…so it is. The actual effect is 25%. I still have more perk ideas—I’ll fix it in the next PR if no one gets to it before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Bombastic Perks Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants