Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bombastic Perks] Add Stormwrought line of playstyle perks #72963

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Apr 11, 2024

Summary

Mods "[Bombastic Perks] Add Stormwrought line of playstyle perks"

Purpose of change

Always wanted to put something into the game that referenced this (aka the Catgirl gene), and finally figured out to a way to do it that's not silly.

Describe the solution

Add a set of playstyle perks, called Stormwrought [X], where [X] is one of Bird, Feline, Insect, Lupine, Plant, or Spider. These trigger EoCs that, when you're out unprotected in a portal storm, run every 5-30 minutes and have a 1/3 chance when they trigger to mutate you in the appropriate category. Post-instability rework, this just uses u_mutate_category, since there's no necessity to use vitamins to track instability anymore. Edit: u_mutate_category seems to automatically bring up the mutation selector which doesn't fit with portal storm randomness, so it's back to mutagen. To work around the issues with u_mutate_category, the EoC adds primer and mutagen, forces a mutation with u_mutate, then removes primer and mutagen to return to baseline, causing one mutation per EoC trigger.

You can only have one Stormwrought perk.

There's no reason to limit it to those mutation lines, I just had to start somewhere.

Describe alternatives you've considered

Testing

Traits exist and are selectable, show up in their own menu (so they don't overwhelm the other Playstyle perks if more are added), and hanging out in a portal storm causes mutation. Mutagen properly removed after mutating. Wearing a 5-point anchor prevents mutation.

Additional context

It'd be nice if u_mutate_category had a kwarg that turned on or off the selector. I double-checked and SHOW_MUTATION_SELECTOR is set as false (the test world just had default mods + Bombastic Perks)

@Standing-Storm Standing-Storm marked this pull request as draft April 11, 2024 15:21
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Bombastic Perks labels Apr 11, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @bombasticSlacks

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 11, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review April 11, 2024 16:45
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 11, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Must not have another Stormwrought perk.
  • Playstyle Perks: Stormwrought
  • Stormwrought Playstyle Perks:\nLevel <u_val:current_level>.\n<u_val:num_perks> perk points to spend.\nCurrent EXP: <u_val:available_exp>.\nEXP to next level: <u_val:exp_to_perk>.
  • Stormwrought: Bird
  • Stormwrought: Feline
  • Stormwrought: Insect
  • Stormwrought: Lupine
  • Stormwrought: Plant
  • Stormwrought: Spider

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 12, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 12, 2024
@Standing-Storm Standing-Storm marked this pull request as draft April 12, 2024 05:59
@Standing-Storm
Copy link
Contributor Author

Drafting to account for threshold breaking with the add mutagen / mutate/ subtract mutagen method. Will implement tomorrow

@Standing-Storm Standing-Storm marked this pull request as ready for review April 12, 2024 13:57
@Standing-Storm
Copy link
Contributor Author

Alright, this approach works and doesn't cause negative primer levels or anything.

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Apr 12, 2024

Edit: Toddler on keyboard leaving comments

@Maleclypse Maleclypse merged commit 64f6f5f into CleverRaven:master Apr 16, 2024
50 of 61 checks passed
@Maleclypse
Copy link
Member

OOH I just realized it would be very thematic for Dinomod to have this for their Dino trees.

@Standing-Storm Standing-Storm deleted the stormwrought-perks branch April 16, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Bombastic Perks Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants