Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault-causing error in _characters_nearby #73041

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "Fix segfault-causing error in _characters_nearby"

Purpose of change

Fixes #73036

Describe the solution

Implement fix proposed by andrei8l

Describe alternatives you've considered

Testing

image

Additional context

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Apr 15, 2024
@Standing-Storm Standing-Storm changed the title Implement fix Fix segfault-causing error in _characters_nearby Apr 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @andrei8l

@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Apr 15, 2024
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
Standing-Storm and others added 2 commits April 15, 2024 09:09
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 15, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Apr 15, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 15, 2024
@Maleclypse Maleclypse merged commit db52cfd into CleverRaven:master Apr 16, 2024
25 checks passed
@Standing-Storm Standing-Storm deleted the fix-character-nearby branch April 16, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using u_characters_nearby in an enchantment value segfaults the game
2 participants