Expand the Russian name list with translated name snippets before #70279 (Help wanted with reviewing)

[Qrox]

Summary

I18N "Expand the Russian name list with translated English names"

Purpose of change

Similar to #73077, add Russian translation of the name snippets from before #70279 to the Russian name file.

Describe the solution

Family and given names from names/en.json are converted to translated names from the Russian mo file before #70279, and added to names/ru.json, using the script in #73083 (comment).

Still a draft because I don't understand Russian and need help reviewing the changes.

Describe alternatives you've considered

Testing

Just regular JSON changes, should be fine if the CI tests pass.

Additional context

I know very little Russian so I'd appreciate some help with reviewing the generated lists. If you would like to help, please go through the lists and mark strings that are not names for removal.

[Vane79]

This file would really benefit from in-line comments of the original names.

[Qrox]

@Hyperseeker @Vane79 thanks a lot for the reviews. I'll look into them.

This file would really benefit from in-line comments of the original names.

I suppose so. I'll see if I can make that happen, but JSON does not support inline comments so it might take some tinkering with the JSON format. It may also require changes to the C++ code if we wish to keep the comments.

[Uwuewsky]

This file would really benefit from not being sorted alphabetically so that it can be opened side-by-side with the original file. And from separating snippet categories into separate files.

I'm not sure it's worth adding translations from a .mo file. File are still significantly different from en.json (fewer names, literal translations).

I planned to work on this file someday. I recently finished what I wanted, so I can take it right now. I can create a separate PR or I can send PR to Qrox:names-ru branch so that my changes appear in this PR. The amount of work is too much to make these changes through suggestions on Github. But it will take some time. Sooo you don't have to worry about this file.

[Qrox]

This file would really benefit from not being sorted alphabetically so that it can be opened side-by-side with the original file

It would if it only contains translated names from en.json, but some of the names from en.json have not been translated, and the current ru.json contains existing names from the previous ru.json and translated names from en.json, so there isn't a strict one-to-one correspondence. I'm not sure where the existing names come from and I'm not planning to dig into the git history to find out 🤷‍♂️.

I might be able to generate a file that contains the source English name in the same order as the current ru.json though.

And from separating snippet categories into separate files.

That should be doable, but is outside the scope of this PR.

I'm not sure it's worth adding translations from a .mo file. File are still significantly different from en.json (fewer names, literal translations).

In some previous version of the game, the names in en.json were copy-pasted into a snippet file, and became translatable on Transifex. Before I noticed and reverted the change in #70279, a significant portion of these strings were already translated into Simplified Chinese, Russian, and Japanese, so that's why I'm salvaging those translations in this PR and #73077.

There is indeed the problem of literal translations for a few of the strings, but from my experience with doing this for the Simplified Chinese file in #73077, only a small part of the strings are affected, so the translations are actually worth salvaging.

Eventually these files should be made translatable on Transifex but I'll have to find out if it supports this kind of files that does not have a one-to-one correspondence between strings. (This is needed because many different names in English might have the same transliteration due to the target langauge having a different set of syllables; the translators might also want to add in names from their own languages.)

I can send PR to Qrox:names-ru branch so that my changes appear in this PR.

Please do, and thanks in advance!

[Hyperseeker]

I wanted to continue the review today, but since @Uwuewsky is working to make a few changes, I'll hold off until they push theirs.

[Qrox]

@Hyperseeker I merged the modification by @Uwuewsky, so the format of the file has changed. There's still a line-to-line correspondence between the name lists so the file can be reviewed by opening the English and Russian files side-by-side.

[Hyperseeker]

So, I've just looked at the latest changes, and... frankly, I'm lost. There's so much to look through, even my browser is struggling.

May I suggest these changes be broken up by category, and split between multiple PRs? City names, first names, nicknames etc. – it would make reviewing them much-easier.

[Qrox]

Sure, I'll break this PR up (and probably merge the English and Russian files for easier review).