-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not count magazine as pocket in the pickup inventory #73107
Do not count magazine as pocket in the pickup inventory #73107
Conversation
can_contain is not checking whether it's watertight or not, the fact is I missed one parameter. |
Well, I was wrong, I did mess it up. |
Summary
Bugfixes "Only count CONTAINER type pockets in the pickup inventory"
Purpose of change
MAGAZINE/MAGAZINE_WELL type pockets don't really serve as pockets the way CONTAINER type pockets do, you can't pick up and hold things with them directly, so don't count them in the pickup inventory.
Close #72807
Describe the solution
When try to pick up frozen_liquid and ammunition_type items, MAGAZINE/MAGAZINE_WELL type pockets that use these items as ammo will no longer be considered. If you don't have any capable CONTAINER type pocket, failure message is returned.
Describe alternatives you've considered
Not to do this.
Testing
Be nude.
Spawn bows, guns, mags, misc repairkit, etc, unload them. Try to pick up ammo while wielding one of them, only to see
Does not fit in any pocket!
.Spawn a water cannon, unload it and pour water on the ground, freeze the water and crush it. Try to pick up ice shard while wielding the water cannon, only to see
Does not have any pocket for frozen liquids!
.Behavior before is shown in #72807.
Additional context