Can't see doesn't close the crafting GUI
#73117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Nothing selected!" instead of "Crafter can't craft that!" when nothing is selected
- popup "Crafter can't see!" rather than closing crafting GUI - In CHOOSE_CRAFTER, display missing: "light" when crafter can't see
github-actions
bot
added
Info / User Interface
|
Restarting tests |
Brambor
changed the title
Can't see doesn't close the crafting GUI
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface ""Can't see" message doesn't close the crafting GUI"
Purpose of change
Before, you would select a recipe, press enter. Nothing happens, but after a second you notice in the log "Can't see to craft." By that time you already forgot what you were crafting.
Describe the solution
Can't see
Pressing CONFIRM pops up a popup "Can't see". The player immediately notices that. They press anything to dismiss it. Remember what they wanted to craft by looking at it. Then they close the crafting GUI.
It might seem like the same state, but the player isn't confused as to why is nothing happening and they do remember what were they crafting.
New "can't see" popup:
Cataclysm_.Dark.Days.Ahead.-.0.G-8892-g12da23f022-dirty.2024-04-19.12-15-54.mp4
query_popup -> popup
Also refactored from
query_popuptopopup. Shorter code and it looks different:before:
after:
Choose crafter
Added "missing:
light" as a reason in the "Choose the crafter" menu why they cannot craft.Nothing selected
When no crafting recipe is selected and CONFIRM is pressed, "Nothing selected!" pops up instead of "Crafter can't craft that!".
Describe alternatives you've considered
Testing
I went through these menus and tried to select different things.
Additional context