Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Tune enhancement spells with scaling modifier #73139

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

MNG-cataclysm
Copy link
Contributor

@MNG-cataclysm MNG-cataclysm commented Apr 19, 2024

Summary

Mods "[Magiclysm] Tune enhancement spells with a scaling modifier."

Purpose of change

Continue improving spellcasting proficiencies and their effects by giving enhancement spells a scaling modifier, like everything else.

Describe the solution

Add a scaling modifier to all enhancement spells and add this to the jmath.

Describe alternatives you've considered

Not doing this.

Testing

Everything works great, buffs get applied properly.

Additional context

Conveyance spells are the only ones remaining at this time to finish, and shouldn't take long.

@github-actions github-actions bot requested a review from KorGgenT April 19, 2024 22:46
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells json-styled JSON lint passed, label assigned by github actions labels Apr 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Cover yourself in dense, invisible energy of Earth. Higher level increase your defence abilities.
  • Reactive Armour
  • Substract some moves from targeted_monster_ids monsters. Subspell; you aren't allowed to see it except in debug mode.
  • Tranform your body to pure spirit, making you invisible and intangible. You can move incredibly quickly while the spell is in effect and can pass by enemies unseen, but you will be unable to affect the physical world or cast spells.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 19, 2024
@Hyperseeker
Copy link
Contributor

Aside from the misspellings, it looks as though this PR is based on an outdated version of the game. For example, it uses FATIGUE instead of SLEEPINESS.

@MNG-cataclysm MNG-cataclysm reopened this Apr 23, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 23, 2024
@MNG-cataclysm
Copy link
Contributor Author

Well, I fixed the spelling issues and the Fatigue -> Sleepiness problem.

@rty275
Copy link
Contributor

rty275 commented Apr 24, 2024

Weird request, but could you by any chance add some documentation in a comment in the jmath file or somewhere to describe how exactly to apply the scaling proficiency thing for new additions for the future? I could probably figure out via trial and error, but it'd make it easier on me and future contributors if we didn't have to have the skills/know-how to read the math to figure out how it works.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 28, 2024
@MNG-cataclysm MNG-cataclysm reopened this Apr 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 29, 2024
@I-am-Erk I-am-Erk merged commit bbc90f0 into CleverRaven:master Apr 30, 2024
35 of 47 checks passed
@MNG-cataclysm MNG-cataclysm deleted the magiclysm_enhancement_fix branch May 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants