-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Tune enhancement spells with scaling modifier #73139
[Magiclysm] Tune enhancement spells with scaling modifier #73139
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Aside from the misspellings, it looks as though this PR is based on an outdated version of the game. For example, it uses |
Well, I fixed the spelling issues and the Fatigue -> Sleepiness problem. |
Weird request, but could you by any chance add some documentation in a comment in the jmath file or somewhere to describe how exactly to apply the scaling proficiency thing for new additions for the future? I could probably figure out via trial and error, but it'd make it easier on me and future contributors if we didn't have to have the skills/know-how to read the math to figure out how it works. |
Summary
Mods "[Magiclysm] Tune enhancement spells with a scaling modifier."
Purpose of change
Continue improving spellcasting proficiencies and their effects by giving enhancement spells a scaling modifier, like everything else.
Describe the solution
Add a scaling modifier to all enhancement spells and add this to the jmath.
Describe alternatives you've considered
Not doing this.
Testing
Everything works great, buffs get applied properly.
Additional context
Conveyance spells are the only ones remaining at this time to finish, and shouldn't take long.