New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce camp z level construction #73176
Open
PatrikLundell
wants to merge
13
commits into
CleverRaven:master
Choose a base branch
from
PatrikLundell:camp_z_construction
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introduce camp z level construction #73176
PatrikLundell
wants to merge
13
commits into
CleverRaven:master
from
PatrikLundell:camp_z_construction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
Scenarios
New Scenarios, balancing, bugs with scenarios
labels
Apr 21, 2024
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Apr 21, 2024
github-actions
bot
removed
the
astyled
astyled PR, label is assigned by github actions
label
Apr 21, 2024
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Apr 21, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 22, 2024
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[Markdown]
Markdown issues and PRs
labels
Apr 22, 2024
This was referenced Apr 22, 2024
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Apr 23, 2024
...n/mapgen/basecamps/expansion/modular_livestock/version_2/modular_livestock_construction.json
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 23, 2024
…_2/modular_livestock_construction.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Apr 23, 2024
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
[Markdown]
Markdown issues and PRs
Scenarios
New Scenarios, balancing, bugs with scenarios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Provide Z level aware camp construction (with a long term goal to separate the unseemly connection between a room and its roof).
Describe the solution
Describe alternatives you've considered
Tried and failed to come up with ways in which this can be partitioned into smaller pieces.
There are outstanding issues (see additional context).
Testing
Additional context
Outstanding issues:
The sexy concrete roof of the chicken coop as seen from the evac shelter's roof: