Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixed frame lag in imgui text inputs"
Purpose of change
Fixed laggy text input in imgui windows.
See #73052. This fixes the issue on macOS. The issue might be the same on
Android (and thus also fixed by this change), but I haven't verified.
Describe the solution
There's an imgui feature that's supposed to prevent "skipping" inputs that
happen quickly by trickling them out one per frame if they happen on the same
key. However, this seems to also be applying to the "keydown" event and then
the "text" event, which both "involve" the same key, even though they're just
two different views of the same event.
This could plausibly be described as an ImGui bug—the trickling behavior could
be useful for repeated down/up/down sequences on a key, perhaps, but it
shouldn't apply to text events—but I'm not sure we really want the trickling
behavior at all, so this patch just disables it.
Describe alternatives you've considered
Testing
Additional context