Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make shopkeeper price rules allow string #73201

Closed
wants to merge 5 commits into from

Conversation

GuardianDll
Copy link
Contributor

@GuardianDll GuardianDll commented Apr 22, 2024

Summary

None

Purpose of change

Required for #73195

Describe the solution

change price_no_contents to use string

Describe alternatives you've considered

None

Testing

TBD

Additional context

Sorry, i don't understand any of this code, it's mostly help of mqrause that made it work, tho i still have some issues not resolved, that i can't fix on my own

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 22, 2024
src/item.h Show resolved Hide resolved
@mqrause
Copy link
Contributor

mqrause commented Apr 23, 2024

The linker error probabl means you need to include units_fwd.h in faction.h.

src/item.h Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Apr 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 23, 2024
src/item.cpp Outdated Show resolved Hide resolved
tests/npc_shop_cons_rates_test.cpp Outdated Show resolved Hide resolved
@GuardianDll
Copy link
Contributor Author

it erroring, it doesn't work, i don't understand the code. Clear sign it should be done by someone smarter than me

@GuardianDll GuardianDll deleted the price_shenanigans branch April 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants