Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major step for rubik's third mission #73221

Merged
merged 19 commits into from Apr 26, 2024

Conversation

I-am-Erk
Copy link
Contributor

@I-am-Erk I-am-Erk commented Apr 24, 2024

Summary

Content "Finish the basic part of rubik's 'find the warehouse' mission, allowing you to ask around for directions; success is not solely RNG"

Purpose of change

Closes #59907

SariusSkelrets added the first part of a major exodii mission in #67695, but in this stub version the mission is a very boring 'find this overmap special' mission. It was left unfinished for a while because, well, busy life, volunteer, etc etc. (this is not the fault of sariusskelrets but of me)

See #59905 for a more full list of what I'd like to do with this mission in the long run. I hope to make it into the first chunk where you can decide if you want to help the exodii or sell them out

Describe the solution

The warehouse rubik asks you to find is now globally unique and quite rare, it's gonna be hard to stumble on it. You can, I hope, but it is hard. However, now you can ask various NPCs around the world if they've seen it. You start with a 1/6 chance of getting the correct directions, but every time you ask a new person, the chance of getting the right directions increases to 1/5, then 1/4, then 1/3, then 1/2, then a guarantee if you have still lost the lottery.

If they don't know where it is, chances are they'll just admit it, but there's 1 in 4 chance they'll send you somewhere else by accident.

Aside from Smokes and the free merchant teamster, you can ask a bunch of random NPCs around the world:

  • the scrap trader
  • the lumbermill logger
  • the random encounters with john bailey, the refugee caravan, or the camper van trader

I'm open to other candidates, but I'd like to avoid anyone else in the refugee center so that it's not the one-stop shop, and I'd like to avoid anyone in the hub for story reasons

I have also cleaned up rubik's dialogue trees a bit because when going through them I spotted some errors and some parts where they were needlessly frustrating to navigate. I confess I'm a little annoyed nobody ever bug reported these >.>

Describe alternatives you've considered

Aside from mildly different implementation I can't think of another way to make the quest more interesting. I plan to add the option to quite a few people around the world so that one way or another you can definitely find someone who's seen it.

After this PR, the next step is to give the player the option to sell the location of the warehouse to the Hub before reporting it back to Rubik. I was thinking of adding it this PR, but I have now got more pressing priorities

Testing

It works!
image

I asked two people and got two possible sites to investigate, which is a neat outcome I hadn't actually anticipated.
image

Smokes, you dick, this is not a concrete building with a metal spire sticking out the top.
image

The teamster did better but this still ain't it chief.
image

Took a few rolls o' the dice but we made it in the end.
image

I am shocked to say this all worked on the first test. It definitely made the mission better. I need to clean up rubik's dialogue linkages a lot.

Additional context

I can't remember if this method will force generation of it if the special doesn't spawn. It should.

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions labels Apr 24, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 24, 2024
@kevingranade
Copy link
Member

We have code for radio triangulation, Rubik could give you a locator device.

@I-am-Erk
Copy link
Contributor Author

We have code for radio triangulation, Rubik could give you a locator device.

The idea is that they can't do this because the transceiver is down, you're going out to reactivate it for them. As a local guide you're better suited than their quads because you can ask around and see if others have seen it.

@SariusSkelrets
Copy link
Contributor

Thank you for finishing the mission. I was incredibly busy these last months (and still am)
It's great to see the Exodii and their content being developped more

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Apr 24, 2024
Copy link
Contributor

@Qrox Qrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize Exodii, to be consistent with rest of the in-game text.

data/json/npcs/exodii/common_talk.json Outdated Show resolved Hide resolved
data/json/npcs/exodii/common_talk.json Outdated Show resolved Hide resolved
data/json/npcs/exodii/common_talk.json Outdated Show resolved Hide resolved
data/json/npcs/exodii/common_talk.json Outdated Show resolved Hide resolved
I-am-Erk and others added 2 commits April 24, 2024 12:26
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 24, 2024
@I-am-Erk I-am-Erk changed the title Finally finish rubik's third mission Next major step for rubik's third mission Apr 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 25, 2024
@I-am-Erk I-am-Erk marked this pull request as ready for review April 26, 2024 04:41
@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Apr 26, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • &Before you stands a towering mass of metal, at least seven feet high, with a large reflective glass plate in the center of its torso. It turns as you enter the room, and raises its hand in a surprisingly natural motion of greeting. A gravelly voice resonates from unseen speakers in the steel frame. Its tone is bizarrely normal, in complete contrast with everything else around you. "Oy, you ain't dead. Lookin' t'trade?" The accent sounds vaguely British, but not familiar; like a terrible imitation of Cockney.
  • *pulls out a sheaf of mismatched papers, and leafs through the pages for a second. Their broad metallic fingers look surprisingly deft and delicate, and incongruous on the otherwise unremarkable looseleaf. "Aye, an' there's room for a pop-an-work roun' here. Rubik's got tassed a lissy, right and clean
  • , but for the right-an-quick, this'n has nothin' t'be tassed for ye."
  • . How'd ye be twigged by a pop-an-squeak? Or as y'r tassed, a treasure hunt?"
  • . How'd ye be twigged by a quick an' round, a nice escoltin' out to a place sommat of curiosity?"
  • . Right and so, mayhap ye should first see about that escoltin'."
  • Aye, business afore, 'tis said. What'll ye tass to ol' Rubik?
  • Fine and you still ain't dead." Their gravelly voice is cheerful. "What brings ye roun' Rubik's neckawoods?
  • Sure as can," the gravelly voice takes on an unmistakeable 'customer service' tone. "What'll ye tass this'n for?

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 26, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 26, 2024
@Maleclypse Maleclypse merged commit 38019b4 into CleverRaven:master Apr 26, 2024
20 of 24 checks passed
@I-am-Erk I-am-Erk deleted the exodii-mission-cross-dialogue branch April 27, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exodii Mission 2 Expansion: Allow NPCs to help you find the warehouse
5 participants