Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge start - hunted forever #73227

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

RenechCDDA
Copy link
Member

@RenechCDDA RenechCDDA commented Apr 24, 2024

Summary

Content "Challenge start - hunted forever. Starts with the nemesis, but it comes back stronger everytime it dies"

Purpose of change

Describe the solution

Add some code to wrap around the nemesis mission causing it to respawn on death unless we've reached the kill count (of 1). Gave the existing nemesis mission a kill count (of 1) so it doesn't respawn. Give any monster with the NEMESIS flag a permanent effect which has a JSON-defined enchantment that powers up as more nemesis die (counter is increased by dead nemesis' death function, can be increased by other JSON means as normal too).

Describe alternatives you've considered

Fully EOC'd?

Testing

Currently in draft because this is not how you do JSON enchantments (it whines that the value isn't constant. Of course it isn't!) It is how you do JSON enchantments! It just wasn't evaluating the values at all, which is why it expected a constant.

Spawned and killed some nemesis, no errors.

Spawned and killed a LOT of nemesis, got punted around like a soccer ball as the super-speedy nemesis proceeded to dash across the screen in a single turn. Debug teleported back towards it and tried to kill it with a tempered steel katana only for the weapon to ineffectually bounce off its now 100+ armor.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Scenarios New Scenarios, balancing, bugs with scenarios <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 24, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • SWOLE

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@RenechCDDA
Copy link
Member Author

Swole is a real word, fight me dictionary bot. You won't. You're not swole.

@Qrox
Copy link
Contributor

Qrox commented Apr 24, 2024

You can make the dictionary swoler with words by adding swole to it.

@RanikOrtega
Copy link
Contributor

I like this idea but man I'd love if instead of just getting a buff, it mutated to 2nd and 3rd forms.

@GuardianDll
Copy link
Member

to what forms?

@RanikOrtega
Copy link
Contributor

RanikOrtega commented Apr 24, 2024

to what forms?

Well This nemesis is a direct reference to RE3 Nemesis. His first form is him running around in coat with bazooka. His second is after he is defeated and regenerates. He loses the weapon but gains tentacle attacks.

re3-2

Third form is basically giant mutated dog thing
re3-3

@GuardianDll
Copy link
Member

i think that's pretty much overkill

@RanikOrtega
Copy link
Contributor

i think that's pretty much overkill

Overkill yes. But I just found it neat and thematic.

@Nebnis
Copy link
Contributor

Nebnis commented Apr 24, 2024

While we don't have to copy resident evil i like the idea of the hulk evolving because eventually the player will get too strong and it will be a nuisance at best

@Standing-Storm
Copy link
Contributor

Looking forward to giving this thing increasingly-strong psionic powers in MoM

@github-actions github-actions bot added Mechanics: Enchantments / Spells Enchantments and spells astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 26, 2024
@RenechCDDA RenechCDDA marked this pull request as ready for review April 26, 2024 11:21
@github-actions github-actions bot requested a review from KorGgenT April 26, 2024 11:21
@RenechCDDA
Copy link
Member Author

Enchantment code/enchantments added to monsters wasn't previously set up to actually evaluate conditions inside the enchantment. Now it is.

@RenechCDDA
Copy link
Member Author

I like this idea but man I'd love if instead of just getting a buff, it mutated to 2nd and 3rd forms.

I don't think we currently have a way to do this in JSON, but if you know of a way I'm open to listening. At the very least this PR just makes a simple provision to respawn the nemesis when appropriate (the new scenario), a little kludge to get the effect onto our nemesis friend, and then all the important JSON-y bits to go from there.

So if we do have a JSON way to do that, it can always be bolted on later. Or the effect and enchantment can be tuned up/down/sideways/whatever as desired.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 26, 2024
@Nebnis
Copy link
Contributor

Nebnis commented Apr 26, 2024

Can you cage him? And prevent the buffs.

I would like to believe that an incremental buff to hp and damage is better than speed and armor. At least not speed so you can run away. I know you might have gone with a doomed to die scenario with this PR, but i would personally like the scenario more if there was just an everlasting growing threat. If his damage increases, he would be able to bash down concrete and stuff too to get to you.

@I-am-Erk
Copy link
Member

Debug teleported back towards it and tried to kill it with a tempered steel katana

Nothing personnel, kid.

@I-am-Erk I-am-Erk merged commit 24ab07a into CleverRaven:master Apr 30, 2024
21 of 28 checks passed
@RenechCDDA RenechCDDA deleted the super_nemesis branch April 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Missions Quests and missions Monsters Monsters both friendly and unfriendly. Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revivable Nemesis
7 participants