Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sky Island] Upgrade central skylight missions and mapgen #73279

Merged
merged 7 commits into from May 3, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Apr 25, 2024

Summary

Mods "[Sky Island] Upgrade central skylight missions and mapgen"

Purpose of change

As your central room gets bigger and bigger, that one-square skylight looks pretty small.

Describe the solution

Adds missions, mapgen, crafting, etc. to allow increasing the size of the central skylight.

Describe alternatives you've considered

Testing

Big skylight:

image

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft April 25, 2024 22:05
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Sky Island Anything about the Sky Island mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 25, 2024
@github-actions github-actions bot added the Missions Quests and missions label Apr 29, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • The central skylight should be enormous to allow in as much light as possible. Time to get to work.\nA new recipe has been learned. Craft this artifact to permanently upgrade the island.\n\nNew Structure: Central Skaylight 4. Expand the central skylight to very generous dimensions.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Standing-Storm Standing-Storm marked this pull request as ready for review April 29, 2024 14:19
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 30, 2024
@Maleclypse Maleclypse merged commit 2963fbb into CleverRaven:master May 3, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the skylight-upgrades branch May 3, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants