Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mushroom ketchup, fried pickled veggies and krampouezh #73301

Merged
merged 9 commits into from Apr 30, 2024

Conversation

BalthazarArgall
Copy link
Contributor

Summary

Content "Add mushroom ketchup, fried pickled veggies and krampouezh"

Purpose of change

Ro din ur c'hrampouezh! We have pancakes yet not their ancestors, also, what if I want to roleplay a Breton?

According to reddit we also lack mushroom ketchup and fried pickles.

Describe the solution

I added the Breton delicacy known by most people as "crepes" to the game, there is a sweet and a not-sweet version along with their recipes.

I also added the mushroom ketchup and a semi-ambitious recipe for frying pickled vegetables, not just pickles!

Describe alternatives you've considered

Testing

To be done.

Additional context

This PR was originally meant to only add krampouezh but I also ran a poll of some kind on reddit last week asking for ideas to add to the game, hence why I would like to thank and credit u/ColeWalkeroftheRim for the fried pickles idea and u/JeveGreen for the mushroom ketchup idea.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 26, 2024
@fairyarmadillo
Copy link
Contributor

You probably want to actually describe what krampouzeh is in its description. "Breton delicacy" isn't very informative.

@BalthazarArgall
Copy link
Contributor Author

You probably want to actually describe what krampouzeh is in its description. "Breton delicacy" isn't very informative.

I 100% intend to change the description, I ended my cdda work session on this very description and commited before reverting it to TODO or something.

@fairyarmadillo
Copy link
Contributor

You probably want to actually describe what krampouzeh is in its description. "Breton delicacy" isn't very informative.

I 100% intend to change the description, I ended my cdda work session on this very description and commited before reverting it to TODO or something.

It's a draft, my bad for reviewing it before it was ready.

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Breton delicacy.
  • TBD.
  • krampouezh
  • krampouezhenn
  • mushroom ketchups
  • sweet krampouezh
  • sweet krampouezhenn

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 29, 2024
@BalthazarArgall BalthazarArgall marked this pull request as ready for review April 29, 2024 11:38
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
@Maleclypse Maleclypse merged commit a98b660 into CleverRaven:master Apr 30, 2024
20 of 24 checks passed
@BalthazarArgall BalthazarArgall deleted the BaltsCornucopia branch April 30, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants