Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disappearing arrows #73346

Merged
merged 1 commit into from Apr 28, 2024

Conversation

nornagon
Copy link
Contributor

Summary

Bugfixes "Fixed arrows disappearing when unwielded"

Purpose of change

Fixes #63933. Arrows were losing their charge count when unwielded (at least on
Android and macOS).

Describe the solution

@mqrause's analysis was correct; the item was being modified by i_rem before
the charge count was accessed. Instead we read off the charge count before
calling i_rem.

Describe alternatives you've considered

Testing

Used the repro steps in the issue:

  1. spawn a hiking backpack and 10 arrows
  2. wear the pack and wield the arrows
  3. unwield the arrows
  4. check the charge count of the arrows

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 28, 2024
@Maleclypse Maleclypse merged commit 9105f03 into CleverRaven:master Apr 28, 2024
22 of 28 checks passed
@I-am-Erk I-am-Erk added the 0.H Backport PR to backport to the 0.H stable release canddiate label Apr 28, 2024
@Procyonae Procyonae mentioned this pull request May 14, 2024
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.G Disappearing arrows
4 participants