Adding support for drawing CJK characters with ImTui #73414
Merged
+108
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Adding support for ImTui to draw unicode characters"
Purpose of change
Fixes: #73205
ImTui out of the box does not support drawing unicode characters. We are adding that here.
Describe the solution
Use a variation of the method employed by #72579 to interrupt the normal drawing flow of imgui to tell ImTui to render the intended characters.
Describe alternatives you've considered
Same as with #72579 , we could simply add all unicode characters to the ImGui cache, which would balloon the memory usage by several gigabytes. this is gross though and we're not doing that
Testing
build curses build, set language to Chinese, Japanese or Korean, load keybindings UI from the main menu and verify the characters draw properly.
Additional context