ImGui popup: switch selected option when lower-case letter is pressed #73420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katemonster33
force-pushed
the
popup_letter_switch_regression
branch
from
65bee02
to
6e0e91b
Compare
github-actions
bot
added
<Bugfix>
github-actions
bot
added
the
BasicBuildPassed
…. 'y' instead of 'Y') did not highlight the intended key.
katemonster33
force-pushed
the
popup_letter_switch_regression
branch
from
6e0e91b
to
b1a2520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes issue where lower-case key does not switch the option in the popup"
Purpose of change
Fixes issue where pressing the lower-cased character of an upper-case popup action does not select the intended button
Describe the solution
modify the correct variable when the key is pressed, the variable being set was re-set every frame, causing the regression.
Describe alternatives you've considered
Testing
Open game, press 'Q' to quit, press 'y' and 'n' keys to change option. rejoice.
Additional context