Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename world creation "Spawn Time Options" to "World Time Options" #73504

Merged
merged 1 commit into from
May 10, 2024

Conversation

theFeu
Copy link
Contributor

@theFeu theFeu commented May 4, 2024

Summary

Interface "Change world setting 'Spawn Time Options' to 'World Time Options'"

Purpose of change

Since the setting for spawn time has moved to the character creation, I think the name for this section should be changed, resolves #73501

Describe the solution

I would suggest calling it "World Time Options" instead, since the contained options are centered around how time flows in the world (season length, construction scaling, eternal seasons, and day/night cycle).

Describe alternatives you've considered

N/A

Testing

I am still trying to figure out how to compile, so not yet tested.
Then again, it is just a string that was changed :)

Additional context

I am not sure if the po files need to be updated (and how). If there is more I should do, let me know!

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 4, 2024
@Qrox
Copy link
Contributor

Qrox commented May 4, 2024

I am not sure if the po files need to be updated

The po files will be automatically updated, you do not need to (and should not) update them manually.

@hexagonrecursion
Copy link
Contributor

Summary

Interface "Change world setting 'Spawn Time Options' to 'Spawn Time Options'"

You made a copy paste error. The second "Spawn Time Options" should be "World Time Options" instead.

@I-am-Erk I-am-Erk merged commit 8f0d773 into CleverRaven:master May 10, 2024
23 of 28 checks passed
@I-am-Erk
Copy link
Member

ah, I didn't notice the interface thing hadn't been fixed. Oh well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename world option "Spawn Time Options"
4 participants