Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anaerobic digester #73523

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

osuphobia
Copy link
Contributor

Summary

Bugfixes "Fix anaerobic digester"

Purpose of change

Fix #73509.

Describe the solution

Fixed the compost_full function, now the loop in Character::i_add_or_drop will not be called again and again.
Also fixed some typo or minor mistakes in comment and description, and deconstruct result of the digester (forgot to change it to the correct result when adding the contents).

Describe alternatives you've considered

N/A

Testing

Follow the steps to reproduce the bug, game will not freeze or lag now.

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 5, 2024
@osuphobia
Copy link
Contributor Author

Oops, forgot to check it without debug pocket, seems that the function will not work as expected after the fix.
This needs further modification🤐

@osuphobia osuphobia marked this pull request as draft May 5, 2024 12:12
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels May 5, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 5, 2024
@osuphobia osuphobia marked this pull request as ready for review May 6, 2024 00:48
@osuphobia
Copy link
Contributor Author

It should be ok now, but we do need something like the liquid_handler but for gases.

@Maleclypse Maleclypse merged commit 5f086e8 into CleverRaven:master May 6, 2024
36 of 40 checks passed
@osuphobia osuphobia deleted the Fix-anaerobic-digester branch May 7, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anaerobic digester causes the game to freeze itself if excessively full.
2 participants