Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bsd cmake build failure #73561

Merged
merged 5 commits into from
May 11, 2024
Merged

Conversation

mmyjona
Copy link
Contributor

@mmyjona mmyjona commented May 7, 2024

Summary

Build "Fix netbsd ncurses build. The ncurses include path is set with CURSES_INCLUDE_DIRS"

Purpose of change

Fix build error when build the ncurse version under *bsd.

  1. The ncurses and ncursesw installed with pkgsrc can be detected with cmake but it should be set in the imtui cmake file explicitly.
  2. The backtrace feature relies on libexecinfo to work properly.

Testing

Pull the code and build it under linux and *bsd.

@mmyjona mmyjona changed the title fix netbsd ncurses build Fix netbsd ncurses build failure May 7, 2024
@github-actions github-actions bot added new contributor Code: Build Issues regarding different builds and build environments labels May 7, 2024
@mmyjona mmyjona changed the title Fix netbsd ncurses build failure [WIP] Fix netbsd ncurses build failure May 7, 2024
@mmyjona mmyjona changed the title [WIP] Fix netbsd ncurses build failure Fix bsd cmake build failure May 8, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 9, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit d78e605 into CleverRaven:master May 11, 2024
17 of 23 checks passed
@mmyjona mmyjona deleted the fix-netbsd-build branch May 11, 2024 08:53
alef added a commit to alef/Cataclysm-DDA that referenced this pull request May 24, 2024
alef added a commit to alef/Cataclysm-DDA that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants