No magic dissectables #73579
Merged
No magic dissectables #73579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
Clang must be appeased |
|
Wow clang being rude, I didn't even do that one. I can deal with it though, I'll push it in a bit. |
RenechCDDA
force-pushed
the
dissection_magic_trick
branch
from
115b6d9
to
975b4bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes some bug(s) (to be linked later™)Apparently this was never reported? But @Karol1223 encountered it when adding dissections to graboids, and they thought it had the same cause as another bug. It does not, so I guess this one doesn't close anything at all.Describe the solution
Don't magic dissectables out of thin air in any circumstance. If we want NO_CORPSE monsters to drop stuff on death we can just give them death_drops in json.
Describe alternatives you've considered
Testing
Gave graboid(NO_CORPSE death type) some sample dissection results. Killed graboid, watched it "split in two" and samples fall out of the sky.
Applied patch, killed graboid again. No magic samples.
Additional context
I tracked when this code was originally added in a #57322 commit and as far as I can tell this was always erroneous?