Use ncurses accessor macros #73586
Merged
Use ncurses accessor macros #73586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would fix #73562 |
github-actions
bot
added
[C++]
|
Just noticed that we don't have a macOS, Curses build which is how this slipped though, maybe think about rearranging the build targets to get coverage for that combination. |
github-actions
bot
added
the
BasicBuildPassed
|
When will this be merged? It's been a bit more than a week since the website was updated. |
When it was merged. Mergers get to things as they come through and see it’s ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
It was pointed out that the experimental builds on cataclysm.org weren't updating, that means one of the release builds is broken.
Fixes #73562
Turns out it's macOS curses build https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/9003013225/job/24732683327#step:27:370
It's broken because macOS defaults to treating the WINDOW struct as opaque, i.e. you're not allowed to directly access data members and must use the accessor macros.
Describe the solution
Use the accessor macros.
Describe alternatives you've considered
You CAN make WINDOW un-opaque, but this is best practice for portability.
Testing
Builds and works locally, I'll need to see if it succeeds the macOS build in CI since I don't have a macOS build env.